codeconsole commented on PR #16499:
URL: https://github.com/apache/grails-core/pull/16499#issuecomment-5980633194
Thanks @matrei, all four addressed:
1. **Disabled registrations and servlet registrations** (55e7e9c293): the
fallback skips registrations with `enabled = false`, and adds the servlet names
of `servletRegistrationBeans` as `AbstractFilterRegistrationBean.configure`
does, so `/*` is only assumed when there are neither URL patterns nor servlet
names.
2. **`?: f.name`** (70470c27f5): guarded on the class name. A class name
containing `$` (lambda, anonymous or proxy class) also falls back to the
registration name.
3. **Docs** (63101a12ac): `grailsCompileStatic.adoc` now mentions the
feature, with the `create-app --features=grails-compile-static` example, after
the `all`/`gsp` example.
4. **Category** (61fa27129b): now `Category.CONFIGURATION`. `LANGUAGES`
wasn't deliberate.
Checked on an 8.0.0-RC2 app with static GSP compilation, both on Tomcat and
with the fallback forced, using three extra registrations:
- a disabled one: not listed
- one mapped with `servletRegistrationBeans =
[ref('dispatcherServletRegistration')]`: listed with that servlet name, after
the URL-pattern matches
- one whose filter is a `$Proxy` class: labelled by its registration name
`GrailsGspSpec`, `GrailsCompileStaticSpec`, `GrailsDefaultPluginsSpec`,
`CreateAppSpec` and `:grails-forge-core:codeStyle` pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
