codeconsole commented on PR #16499: URL: https://github.com/apache/grails-core/pull/16499#issuecomment-5982040815
Thanks @matrei. I took up the dispatcher-type thought here rather than in a follow-up. - **Dispatcher types** (7599fa986f): each row now carries its map's dispatcher types, `REQUEST` where the map states none, as Tomcat assumes. A map that leaves out `REQUEST` is badged with the types it is for, so an `ERROR`-only map no longer reads as part of an ordinary request's chain. Only those maps are badged, since every `OncePerRequestFilter` is mapped for all five types and badging every row would be noise. Off Tomcat, a Spring Boot registration's types come from `determineDispatcherTypes()`; the Servlet API doesn't expose them for the container's other filters. Both test examples register an `ERROR`-only filter and check its badge, and both specs fail with the badge removed. - **`grails-compile-static`** (cdc35cb97a): the generated block now sets `controllers`, `services` and `tagLibs` individually instead of `all = true`, so an artefact type a later release adds to `all` isn't compiled statically in a generated application on upgrade without anyone asking for it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
