matrei opened a new pull request, #16513: URL: https://github.com/apache/grails-core/pull/16513
## Description Updates the Asciidoctor Gradle plugin (`org.asciidoctor:asciidoctor-gradle-jvm`) from 4.0.5 to [5.0.2](https://github.com/asciidoctor/asciidoctor-gradle-plugin/releases/tag/release_5_0_2). Version 5 publishes the task-based plugins under new IDs (`org.asciidoctor.jvm.convert` is now `org.asciidoctor.jvm.convert.classic`), and the old ID has no 5.x release. See the plugin's [upgrade notes](https://docs.asciidoctor.org/gradle-plugin/latest/upgrading/). - **Versions:** `dependencies.gradle` (and so `grails-gradle-bom`) and `grails-forge/gradle.properties` move to 5.0.2. - **Docs builds:** the data-mapping docs builds and `grails-doc` apply `org.asciidoctor.jvm.convert.classic`. Their task configuration is unchanged. - **`settings.gradle`:** the note about 4.0.5's `StartParameter.isConfigurationCacheRequested` deprecation (removed in Gradle 10) is gone, because 5.0.2 no longer triggers it. - **Forge `asciidoctor` feature:** generated applications apply `org.asciidoctor.jvm.convert.classic` 5.0.2 and set AsciidoctorJ 3.0.1. The plugin declares AsciidoctorJ 3.0.1, and the 3.0.0 the feature generated before pins it back to 3.0.0 with JRuby 9.4.8.0. With that combination, the `asciidoctor` task fails with `LoadError: no such file to load -- asciidoctor`. - **Upgrade guide:** a new section, 1.2 "Asciidoctor Gradle Plugin 5", covers the plugin ID and the AsciidoctorJ 3.0.1 requirement for applications generated by Grails 7. The data-mapping docs builds don't set an AsciidoctorJ version, so they move from the 4.0.5 default (AsciidoctorJ 2.5.7, Asciidoctor 2.0.18) to the 5.0.2 default (AsciidoctorJ 3.0.1, Asciidoctor 2.0.26). That is the version `grails-doc` already uses. During configuration of the docs projects, the plugin prints Grolifant notices that some `ProjectOperations` methods will be removed in Grolifant 6.0. They come from the plugin's own classic code, not from our build scripts. ## Testing - **Docs output:** I ran the `asciidoctor` task of all seven data-mapping docs projects on `8.0.x` and on this branch. Across all 368 HTML pages, only the `generator` meta tag and the default stylesheet differ; the page bodies are identical. The 4.0.5 run prints the `StartParameter.isConfigurationCacheRequested` deprecation and this branch doesn't. - **Generated application:** I built a project from the feature's generated plugin line, `gradle/asciidoc.gradle` and `index.adoc`, and ran `asciidoctor` on Gradle 9.8. - With 5.0.2 and AsciidoctorJ 3.0.1, it renders, including the PlantUML diagram. - With 5.0.2 and AsciidoctorJ 3.0.0, it fails with the `LoadError` above. - With 4.0.5 and AsciidoctorJ 3.0.0, it renders. - **Forge:** all `grails-forge-core` tests pass (372, including `AsciidoctorSpec`), and so does `:grails-forge-core:codeStyle`. - **Root build:** `validateBomProperties`, `validateDependencyVersions` and `:grails-doc:publishGuide` pass. `clean aggregateViolations` reports no Checkstyle, CodeNarc, PMD or repository-convention violations. I didn't run the root test suite locally, since no root code changes; CI covers it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
