matrei commented on code in PR #16513:
URL: https://github.com/apache/grails-core/pull/16513#discussion_r4215438270
##########
grails-data-hibernate5/docs/build.gradle:
##########
@@ -21,7 +21,7 @@ import org.asciidoctor.gradle.jvm.AsciidoctorTask
plugins {
id 'groovy'
- id 'org.asciidoctor.jvm.convert'
+ id 'org.asciidoctor.jvm.convert.classic'
Review Comment:
The `NoClassDefFoundError` isn't the task's own error. The classic
`asciidoctor` task runs AsciidoctorJ inside the Gradle daemon, in an isolated
class loader (4.0.5 did the same). The task failed with a JRuby exception.
Gradle only reads that exception's message at the end of the build, and
computing it runs Ruby code that needs `JavaLang$Throwable`. By then the
worker's class loader is closed, so the class can't be loaded and the real
message is lost. The stack trace shows this: `RaiseException.getMessage` is
called from `DefaultFailureFactory` in
`BuildOutcomeReportingBuildActionRunner`, 4.5 minutes after the task was marked
FAILED.
I couldn't reproduce it. On JDK 25.0.3 I ran the Hibernate 5, Hibernate 7,
MongoDB, developer guide and what's new `asciidoctor` tasks together with
`--max-workers=4` six times, and they all passed. I've moved the PR to 5.0.3.
That release doesn't change the classic plugin code, so it isn't a fix for
this. The CI run on 5.0.3 passed, including `Build Grails-Core (Ubuntu JDK
25)`, so the failure looks intermittent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
