amondel2 commented on code in PR #432:
URL:
https://github.com/apache/grails-intellij-plugin/pull/432#discussion_r4191349519
##########
plugin/src/main/java/org/apache/grails/intellij/plugin/projectView/impl/Grails3NodeProvider.java:
##########
@@ -36,13 +42,22 @@
import java.util.ArrayList;
import java.util.Collection;
+import java.util.HashSet;
import java.util.List;
+import java.util.Set;
+import javax.swing.Icon;
public class Grails3NodeProvider implements GrailsViewNodeProvider {
private static final List<String> SPECIAL_FILES = List.of("build.gradle",
"settings.gradle", "gradle.properties");
private static final List<String> SPECIAL_DIRS = List.of("src/main/scripts",
"src/main/webapp");
+ /**
+ * Grails 7 kebab-case test source roots under {@code src/}. The Grails 6
camelCase roots
Review Comment:
Fixed in `e1ad4a0`. You're right on both counts, and I checked before
rewriting: `IntegrationTestGradlePlugin` has used `sourceFolderName =
'src/integration-test'` since Grails 3 — identically in grails-gradle-plugin
5.3.1 and on grails-core 8.0.x — so kebab-case is not a Grails 7 change. And no
Grails version generates camelCase test roots, so there is no Grails 6
convention to contrast with.
The javadoc now says the three names are the Grails 3+ test source roots. I
also renamed `testCamelCaseTestRootsStayUnderSrc` rather than deleting it: it
still pins a real property, that a folder under `src` holding none of the
conventional code source directories stays inside the `src` node, and its
messages now say that in words. A third stale "Grails 7" claim in the same
file, on `findTestSourceDirectories`, went wit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
