amondel2 commented on code in PR #432: URL: https://github.com/apache/grails-intellij-plugin/pull/432#discussion_r4191378582
########## plugin/src/test/java/org/apache/grails/intellij/plugin/projectView/impl/GrailsAppNodeProviderTest.java: ########## @@ -0,0 +1,260 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.grails.intellij.plugin.projectView.impl; + +import com.intellij.icons.AllIcons; +import com.intellij.ide.projectView.PresentationData; +import com.intellij.ide.projectView.ViewSettings; +import com.intellij.ide.projectView.impl.nodes.PsiDirectoryNode; +import com.intellij.ide.projectView.impl.nodes.PsiFileSystemItemFilter; +import com.intellij.ide.util.treeView.AbstractTreeNode; +import com.intellij.openapi.project.Project; +import com.intellij.psi.PsiDirectory; +import com.intellij.psi.PsiManager; +import org.jetbrains.annotations.NotNull; +import org.jetbrains.annotations.Nullable; +import org.apache.grails.intellij.plugin.artefact.api.GrailsDisplayableArtefactHandler; +import org.apache.grails.intellij.plugin.artefact.impl.ControllerArtefactHandler; +import org.apache.grails.intellij.plugin.artefact.impl.DomainArtefactHandler; +import org.apache.grails.intellij.plugin.artefact.impl.InterceptorArtefactHandler; +import org.apache.grails.intellij.plugin.artefact.impl.ServiceArtefactHandler; +import org.apache.grails.intellij.plugin.artefact.impl.TaglibArtefactHandler; +import org.apache.grails.intellij.plugin.projectView.NodeWeights; +import org.apache.grails.intellij.plugin.projectView.nodes.GrailsApplicationNode; +import org.apache.grails.intellij.plugin.projectView.nodes.GrailsArtefactHandlerNode; +import org.apache.grails.intellij.plugin.projectView.nodes.GrailsPsiDirectoryNode; +import org.apache.grails.intellij.plugin.projectView.nodes.OtherGrailsAppSourcesNode; +import org.apache.grails.intellij.plugin.structure.GrailsApplication; + +import java.util.Collection; +import java.util.Set; +import java.util.stream.Collectors; +import javax.swing.Icon; + +public class GrailsAppNodeProviderTest extends GrailsNodeProviderTestSupport { + + public void testRendersTranslationsAndAssetSubfolderNodes() { + addAssetAndTranslationFixture(); + + Collection<AbstractTreeNode<?>> nodes = new GrailsAppNodeProvider().createNodes(testApplication(true), ViewSettings.DEFAULT); + + GrailsPsiDirectoryNode translations = findNode(nodes, "i18n"); + assertNotNull("Translations node must be present", translations); + assertEquals(NodeWeights.TRANSLATIONS_FOLDER, translations.getNodeWeight()); + assertSame(AllIcons.FileTypes.Properties, translations.getNodeIcon()); + + GrailsPsiDirectoryNode stylesheets = findNode(nodes, "stylesheets"); + assertNotNull("Stylesheets node must be present", stylesheets); + assertEquals(NodeWeights.STYLESHEETS_FOLDER, stylesheets.getNodeWeight()); + assertSame(AllIcons.FileTypes.Css, stylesheets.getNodeIcon()); + + GrailsPsiDirectoryNode images = findNode(nodes, "images"); + assertNotNull("Images node must be present", images); + assertEquals(NodeWeights.IMAGES_FOLDER, images.getNodeWeight()); + assertSame(AllIcons.FileTypes.Image, images.getNodeIcon()); + + GrailsPsiDirectoryNode javascripts = findNode(nodes, "javascripts"); + assertNotNull("JavaScripts node must be present", javascripts); + assertEquals(NodeWeights.JAVASCRIPTS_FOLDER, javascripts.getNodeWeight()); + assertSame(AllIcons.FileTypes.JavaScript, javascripts.getNodeIcon()); + + GrailsPsiDirectoryNode utils = findNode(nodes, "utils"); + assertNotNull("Utils node must be present", utils); + assertEquals(NodeWeights.UTILS_FOLDER, utils.getNodeWeight()); + assertSame(AllIcons.Nodes.Class, utils.getNodeIcon()); + + GrailsPsiDirectoryNode migrations = findNode(nodes, "migrations"); + assertNotNull("Migrations node must be present", migrations); + assertEquals(NodeWeights.MIGRATIONS_FOLDER, migrations.getNodeWeight()); + assertSame(AllIcons.Nodes.DataSchema, migrations.getNodeIcon()); + } + + public void testRendersTitlesForNewNodes() { + addAssetAndTranslationFixture(); + + Collection<AbstractTreeNode<?>> nodes = new GrailsAppNodeProvider().createNodes(testApplication(true), ViewSettings.DEFAULT); + + assertPresentation(findNode(nodes, "i18n"), "Translations", AllIcons.FileTypes.Properties); + assertPresentation(findNode(nodes, "utils"), "Utils", AllIcons.Nodes.Class); + assertPresentation(findNode(nodes, "migrations"), "Migrations", AllIcons.Nodes.DataSchema); + assertPresentation(findNode(nodes, "images"), "Images", AllIcons.FileTypes.Image); + assertPresentation(findNode(nodes, "javascripts"), "JavaScripts", AllIcons.FileTypes.JavaScript); + assertPresentation(findNode(nodes, "stylesheets"), "Stylesheets", AllIcons.FileTypes.Css); + } + + public void testMissingAssetSubfolderProducesNoNode() { + myFixture.addFileToProject("grails-app/i18n/messages.properties", "a=b"); + myFixture.addFileToProject("grails-app/assets/stylesheets/app.css", "h1 {}"); + + Collection<AbstractTreeNode<?>> nodes = new GrailsAppNodeProvider().createNodes(testApplication(true), ViewSettings.DEFAULT); + + assertNotNull("Stylesheets node must be present", findNode(nodes, "stylesheets")); + assertNull("no Images node when assets/images is absent (FR7)", findNode(nodes, "images")); Review Comment: Fixed in `e1ad4a0`. Removed from both test classes; each message now states the property in words. You were right that the numbers are useless to a reader — they point at a requirements document that isn't in the repository, and they don't match the other PRD's numbering either. A repo-wide grep for `FR[0-9]` over the sources is clean now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
