jdaugherty commented on code in PR #16768: URL: https://github.com/apache/grails-core/pull/16768#discussion_r4379606259
########## grails-doc/src/en/guide/upgrading/upgrading81x.adoc: ########## @@ -72,3 +72,19 @@ grailsApplication.config.refresh() `refresh()` is a method of the configuration implementation rather than of the `Config` interface, so it is a call for dynamically compiled test code and may change with the implementation. It reads the environment again and merges the property sources again, which replaces a value the test set on the configuration directly wherever a property source defines the same key. Call it again once the variables are removed: the configuration keeps the environment it last read. Two smaller differences: variable names are upper-cased with `Locale.ROOT`, as Spring does, so a key containing `i` matches its upper-cased variable under a Turkish default locale too; and `getProperty(null)` returns the default value instead of throwing a `NullPointerException`. + +==== 5. The Character Encoding Filter Runs First Review Comment: I think we should probably make the upgrade skill generic and have it versioned per Grails version too - that way w'ere not maintaining multiple ones? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
