jamesfredley commented on code in PR #16768:
URL: https://github.com/apache/grails-core/pull/16768#discussion_r4381326705
##########
grails-web-common/src/main/groovy/org/grails/web/config/http/GrailsFilters.java:
##########
@@ -28,7 +30,14 @@ public enum GrailsFilters {
FIRST,
ASSET_PIPELINE_FILTER,
- CHARACTER_ENCODING_FILTER,
+
+ /**
+ * Runs ahead of every other filter, as Spring Boot's own encoding filter
does. A filter that reads a request
+ * parameter before the encoding is set makes the servlet container decode
the request body with its default
+ * charset (ISO-8859-1), for the rest of the request.
+ */
+ CHARACTER_ENCODING_FILTER(Ordered.HIGHEST_PRECEDENCE),
Review Comment:
This is now `Ordered.HIGHEST_PRECEDENCE`. `SpringSecurityCasGrailsPlugin`
still registers single sign-out at that same order. An explicit
`FilterRegistrationBean` wins the tie, so CAS still reads parameters before the
encoding is set.
Register CAS at `HIGHEST_PRECEDENCE + 1`. Please post a non-ASCII form with
single sign-out enabled and assert the text arrives as typed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
