borinquenkid commented on PR #16572:
URL: https://github.com/apache/grails-core/pull/16572#issuecomment-6461282589
@jdaugherty @matrei @jamesfredley
The branch history has been rebuilt directly on `10.0.x` into the strict
two-commit structure:
1. **Commit 1 (`92c41267a0`)**: `git mv` only across all 326 `.java` files
(including `CompositeUserTypeBinder` and `CompositeUserTypeColumns` from merged
#16695). Every line is `R100` with 0 content modifications.
2. **Commit 2 (`a3b6fa56d6`)**: Pure conversion to statically-compiled
Groovy addressing all review items:
- **Idiomatic Style**: Stripped trailing semicolons, plain double quotes,
legacy `TODO(groovyism-cleanup)` comments, and `UnnecessarySemicolon` / PMD /
SpotBugs suppressions.
- **Static Compilation**: `@CompileStatic` is present across all
converted types, traits, enums, records, and `dbmigration-core` test/fixture
classes.
- **Records**: Annotated with `@RecordOptions(getAt = false, toList =
false, toMap = false, size = false)` and `@TupleConstructor(defaults = false,
namedVariant = false)`. `SqlRestriction` defines an explicit canonical
constructor and handles the CodeNarc component indentation false-positive with
`@SuppressWarnings('Indentation')`.
- **Binary Compatibility & API**: Preserved Java-facing API contracts,
`@PackageScope` on package-private helpers (`hibernateFlushModeToConstant`),
direct field access (`currentEntry.@direction`), explicit receivers on shadowed
parameter names (`this.sqlRestriction(...)` /
`HibernateDetachedCriteriaExtension.sqlRestriction(...)`), and compile-time
verification via `JavaCallerPin.java`.
- **Scope Discipline**: Purged unmerged logic from open PRs (#16686).
- **Agent Skill**: Added
`.agents/skills/java-to-groovy-conversion/SKILL.md` (unreleased framework
skill) and registered in `AGENTS.md` and `.agents/skills/README.md`.
- **Verification**: `codeStyle`, `codenarcMain`,
`validateRepositoryConventions`, and `rat` pass cleanly without violations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
