[
https://issues.apache.org/jira/browse/GROOVY-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15902862#comment-15902862
]
Paul King edited comment on GROOVY-8097 at 3/9/17 10:39 AM:
------------------------------------------------------------
[~yetanotherion] WRT this:
{quote}
Do we have other arguments available in Grab that would permit implementing
such a functionality?
{quote}
I imagine you'd either have a new dedicated annotation attribute on @GrabConfig:
{code}
@GrabConfig(resolutionCacheDir='/someCacheDir')
{code}
This is leaking a tiny bit of Ivy specifics but no worse than the current
disableChecksums attribute. Future versions of Groovy might deprecate either of
those attributes.
I imagine you'd keep the same mechanism to pass to Grape.grab as exists now for
disableChecksums, e.g.
{code}
@GrabConfig(resolutionCacheDir='/someCacheDir')
@Grab('....dep1...')
@Grab('....dep2...')
{code}
would become:
{code}
Grape.grab([resolutionCacheDir: '/someCacheDir'], [...dep1_details...],
[...dep2_details...])
{code}
Alternatively, you could use a system property:
{code}
@GrabConfig(systemProperties='groovy.grape.resolutionCacheDir=/someCacheDir')
{code}
Although I imagine that just looking for the system property is just as easy.
was (Author: paulk):
[~yetanotherion] WRT this:
{quote}
Do we have other arguments available in Grab that would permit implementing
such a functionality?
{quote}
I imagine you'd either have a new dedicated annotation attribute on @GrabConfig:
{code}
@GrabConfig(resolutionCacheDir='/someCacheDir')
{code}
This is leaking a tiny bit of Ivy specifics but no worse than the current
disableChecksums attribute. Future versions of Groovy might deprecate either of
those attributes.
I imagine you'd keep the same mechanism to pass to Grape.grab as exists now for
disableChecksums, e.g.
{code}
@GrabConfig(resolutionCacheDir='/someCacheDir')
@Grab('....dep1...')
@Grab('....dep2...')
{code}
would become:
{code}
Grape.grab([resolutionCacheDir: '/someCacheDir'], [...dep1_details...],
[...dep2_details...])
{code}
Alternatively, you could use a system property:
{code}
@GrabConfig(systemProperties='groovy.grape.resolutionCacheDir=/someCacheDir')
{code}
> Add an argument to set the resolution cache path in @Grab
> ---------------------------------------------------------
>
> Key: GROOVY-8097
> URL: https://issues.apache.org/jira/browse/GROOVY-8097
> Project: Groovy
> Issue Type: New Feature
> Components: Grape
> Affects Versions: 2.4.8
> Reporter: Ion Alberdi
> Priority: Minor
>
> Ivy does not support concurrent access to its resolution cache
> https://issues.apache.org/jira/browse/IVY-654
> Grape relies on Ivy. For this reason, Grape cannot support concurrent access
> to its resolution cache neither.
> When using the @Grab annotation in jenkins groovyCommand or
> systemGroovyCommand, the related code is vulnerable to race conditions. When
> the race condition appears in a systemGroovyCommand, we have no choice but to
> reboot jenkins as all consecutive calls to @Grab fail.
> Among the two solutions we tried:
> - Protect the calls to grab with a lock similar to ivy's "artifact-lock-nio"
> strategy. Works but slow.
> - Set Ivy's lock on the repository cache and setup Grab to use a different
> cache resolution cache for each concurrent jobs. The following code permits
> to fix a test we did to reproduce the race condition.
> {code}
> static IvySettings createIvySettings(String resolutionPath, boolean
> dumpSettings) {
> // Copy/Paste/Purged from GrapeIvy.groovy
> IvySettings settings = new IvySettings()
> settings.load(new File(GROOVY_HOME, "grapeConfig.xml"))
> // set up the cache dirs
> settings.defaultCache = new File(GRAPES_HOME)
> settings.setVariable("ivy.default.configuration.m2compatible", "true")
> settings.setDefaultResolutionCacheBasedir(resolutionPath)
> return settings
> }
> static GrapeIvy ivyWithCustomResolutionPath(String resolutionPath) {
> Class<?> grapeIvyClass = Class.forName("groovy.grape.GrapeIvy");
> Object instance = grapeIvyClass.newInstance()
> Field field = grapeIvyClass.getDeclaredField("ivyInstance");
> field.setAccessible(true);
> field.set(instance,
> Ivy.newInstance(createIvySettings(resolutionPath)));
> return ((GrapeIvy)instance)
> }
> {code}
> We'd like to propose to add an additional argument to Grab to setup Ivy's
> resolution cache directory.
> Note that this solution seems to have been adopted by these users too
> https://rbcommons.com/s/twitter/r/3436/
> Would you agree on such a feature ? We'd be glad to propose a PR.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
