[ https://issues.apache.org/jira/browse/GROOVY-9236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16919766#comment-16919766 ]
Eric Milles commented on GROOVY-9236: ------------------------------------- Is there some measurement of the # of lookups reduced or time saved? The risk of altering this area of the code seems very high, so I would expect the benefit to also be high in order to justify the change. > Avoid unnecessary resolving > --------------------------- > > Key: GROOVY-9236 > URL: https://issues.apache.org/jira/browse/GROOVY-9236 > Project: Groovy > Issue Type: Improvement > Reporter: Daniel Sun > Assignee: Daniel Sun > Priority: Major > Fix For: 3.0.0-beta-4 > > Time Spent: 1h 50m > Remaining Estimate: 0h > > {{ResolveVisitor}}'s {{resolveFromStaticInnerClasses}}, > {{resolveFromDefaultImports}} and {{resolveNestedClass}} will try to guess > class qualified name and load. In the process of resolving, lots of time > wasted on finding non-existing classes. So we should try to resolve classes > in a determined manner. > For example, > For {{java.util.stream.Collectors}}, ① {{resolveFromStaticInnerClasses}} > will try to guess {{java.util.stream$Collectors}}, > {{java.util$stream$Collectors}}, {{java$util$stream$Collectors}}. > And ② {{resolveFromDefaultImports}} will guess > {{java.lang.java$util$stream$Collectors}}, > {{java.util.java$util$stream$Collectors}}, ..., > {{groovy.lang.java$util$stream$Collectors}}. > After the precedence of resolving adjusted, the above unnecessary resolving > can be avoided. -- This message was sent by Atlassian Jira (v8.3.2#803003)