nescohen commented on a change in pull request #1391:
URL: https://github.com/apache/groovy/pull/1391#discussion_r498487633
##########
File path: src/main/java/org/codehaus/groovy/classgen/EnumCompletionVisitor.java
##########
@@ -83,7 +83,13 @@ private void completeEnum(ClassNode enumClass) {
private static void addImplicitConstructors(ClassNode enumClass, boolean
aic) {
if (aic) {
ClassNode sn = enumClass.getSuperClass();
- List<ConstructorNode> sctors = new
ArrayList<ConstructorNode>(sn.getDeclaredConstructors());
Review comment:
I was looking specifically at this function:
https://github.com/nescohen/groovy/blob/master/src/main/java/org/codehaus/groovy/ast/ClassNode.java#L1014
I made the assumption that it was possible for the return value to be null
specifically because of the null check on line 1014. It is possible this was a
mistake however. I did not look at/consider the actual call to
`redirect().getUnresolvedSuperClass();`. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
