eric-milles commented on a change in pull request #1391:
URL: https://github.com/apache/groovy/pull/1391#discussion_r498489873



##########
File path: src/main/java/org/codehaus/groovy/classgen/EnumCompletionVisitor.java
##########
@@ -83,7 +83,13 @@ private void completeEnum(ClassNode enumClass) {
     private static void addImplicitConstructors(ClassNode enumClass, boolean 
aic) {
         if (aic) {
             ClassNode sn = enumClass.getSuperClass();
-            List<ConstructorNode> sctors = new 
ArrayList<ConstructorNode>(sn.getDeclaredConstructors());

Review comment:
       I had a bit of confusion.  `getDeclaredConstructors()` is what I was 
referring to.  `getSuperClass()` may return null for an interface but should 
return `java.lang.Enum` for an enum class.  If that isn't the case, there is a 
problem upstream where `enumClass` is created.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to