sonatype-lift[bot] commented on code in PR #1785:
URL: https://github.com/apache/groovy/pull/1785#discussion_r984915270
##########
src/main/java/org/codehaus/groovy/runtime/DefaultGroovyMethods.java:
##########
@@ -11693,108 +11299,44 @@ public static boolean asBoolean(Object[] array) {
return array != null && array.length > 0;
}
- /**
- * Coerces a byte array to a boolean value.
- * A byte array is false if the array is of length 0,
- * and true otherwise.
- *
- * @param array an array
- * @return the array's boolean value
- * @since 1.7.4
- */
+ @Deprecated
public static boolean asBoolean(byte[] array) {
- return array != null && array.length > 0;
+ return ArrayGroovyMethods.asBoolean(array);
}
- /**
- * Coerces a short array to a boolean value.
- * A short array is false if the array is of length 0,
- * and true otherwise.
- *
- * @param array an array
- * @return the array's boolean value
- * @since 1.7.4
- */
+ @Deprecated
public static boolean asBoolean(short[] array) {
- return array != null && array.length > 0;
+ return ArrayGroovyMethods.asBoolean(array);
}
- /**
- * Coerces an int array to a boolean value.
- * An int array is false if the array is of length 0,
- * and true otherwise.
- *
- * @param array an array
- * @return the array's boolean value
- * @since 1.7.4
- */
+ @Deprecated
public static boolean asBoolean(int[] array) {
- return array != null && array.length > 0;
+ return ArrayGroovyMethods.asBoolean(array);
}
- /**
- * Coerces a long array to a boolean value.
- * A long array is false if the array is of length 0,
- * and true otherwise.
- *
- * @param array an array
- * @return the array's boolean value
- * @since 1.7.4
- */
+ @Deprecated
public static boolean asBoolean(long[] array) {
- return array != null && array.length > 0;
+ return ArrayGroovyMethods.asBoolean(array);
}
- /**
- * Coerces a float array to a boolean value.
- * A float array is false if the array is of length 0,
- * and true otherwise.
- *
- * @param array an array
- * @return the array's boolean value
- * @since 1.7.4
- */
+ @Deprecated
public static boolean asBoolean(float[] array) {
- return array != null && array.length > 0;
+ return ArrayGroovyMethods.asBoolean(array);
}
- /**
- * Coerces a double array to a boolean value.
- * A double array is false if the array is of length 0,
- * and true otherwise.
- *
- * @param array an array
- * @return the array's boolean value
- * @since 1.7.4
- */
+ @Deprecated
public static boolean asBoolean(double[] array) {
Review Comment:
*[InlineMeSuggester](https://errorprone.info/bugpattern/InlineMeSuggester):*
This deprecated API looks inlineable. If you'd like the body of the API to be
inlined to its callers, please annotate it with @InlineMe.
---
```suggestion
@InlineMe(replacement = "ArrayGroovyMethods.asBoolean(array)", imports =
"org.codehaus.groovy.runtime.ArrayGroovyMethods")
```
---
<details><summary><b>âšī¸ Learn about @sonatype-lift commands</b></summary>
You can reply with the following commands. For example, reply with
***@sonatype-lift ignoreall*** to leave out all findings.
| **Command** | **Usage** |
| ------------- | ------------- |
| `@sonatype-lift ignore` | Leave out the above finding from this PR |
| `@sonatype-lift ignoreall` | Leave out all the existing findings from this
PR |
| `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified
`file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
**Note:** When talking to LiftBot, you need to **refresh** the page to see
its response.
<sub>[Click here](https://github.com/apps/sonatype-lift/installations/new)
to add LiftBot to another repo.</sub></details>
---
Was this a good recommendation?
[ [đ Not
relevant](https://www.sonatype.com/lift-comment-rating?comment=340737545&lift_comment_rating=1)
] - [ [đ Won't
fix](https://www.sonatype.com/lift-comment-rating?comment=340737545&lift_comment_rating=2)
] - [ [đ Not critical, will
fix](https://www.sonatype.com/lift-comment-rating?comment=340737545&lift_comment_rating=3)
] - [ [đ Critical, will
fix](https://www.sonatype.com/lift-comment-rating?comment=340737545&lift_comment_rating=4)
] - [ [đ Critical, fixing
now](https://www.sonatype.com/lift-comment-rating?comment=340737545&lift_comment_rating=5)
]
##########
src/main/java/org/codehaus/groovy/runtime/DefaultGroovyMethods.java:
##########
@@ -11693,108 +11299,44 @@ public static boolean asBoolean(Object[] array) {
return array != null && array.length > 0;
}
- /**
- * Coerces a byte array to a boolean value.
- * A byte array is false if the array is of length 0,
- * and true otherwise.
- *
- * @param array an array
- * @return the array's boolean value
- * @since 1.7.4
- */
+ @Deprecated
public static boolean asBoolean(byte[] array) {
- return array != null && array.length > 0;
+ return ArrayGroovyMethods.asBoolean(array);
}
- /**
- * Coerces a short array to a boolean value.
- * A short array is false if the array is of length 0,
- * and true otherwise.
- *
- * @param array an array
- * @return the array's boolean value
- * @since 1.7.4
- */
+ @Deprecated
public static boolean asBoolean(short[] array) {
Review Comment:
*[InlineMeSuggester](https://errorprone.info/bugpattern/InlineMeSuggester):*
This deprecated API looks inlineable. If you'd like the body of the API to be
inlined to its callers, please annotate it with @InlineMe.
---
```suggestion
@InlineMe(replacement = "ArrayGroovyMethods.asBoolean(array)", imports =
"org.codehaus.groovy.runtime.ArrayGroovyMethods")
```
---
<details><summary><b>âšī¸ Learn about @sonatype-lift commands</b></summary>
You can reply with the following commands. For example, reply with
***@sonatype-lift ignoreall*** to leave out all findings.
| **Command** | **Usage** |
| ------------- | ------------- |
| `@sonatype-lift ignore` | Leave out the above finding from this PR |
| `@sonatype-lift ignoreall` | Leave out all the existing findings from this
PR |
| `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified
`file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
**Note:** When talking to LiftBot, you need to **refresh** the page to see
its response.
<sub>[Click here](https://github.com/apps/sonatype-lift/installations/new)
to add LiftBot to another repo.</sub></details>
---
Was this a good recommendation?
[ [đ Not
relevant](https://www.sonatype.com/lift-comment-rating?comment=340737650&lift_comment_rating=1)
] - [ [đ Won't
fix](https://www.sonatype.com/lift-comment-rating?comment=340737650&lift_comment_rating=2)
] - [ [đ Not critical, will
fix](https://www.sonatype.com/lift-comment-rating?comment=340737650&lift_comment_rating=3)
] - [ [đ Critical, will
fix](https://www.sonatype.com/lift-comment-rating?comment=340737650&lift_comment_rating=4)
] - [ [đ Critical, fixing
now](https://www.sonatype.com/lift-comment-rating?comment=340737650&lift_comment_rating=5)
]
##########
src/main/java/org/codehaus/groovy/runtime/DefaultGroovyMethods.java:
##########
@@ -3178,116 +3179,44 @@ public static <T> Number count(T[] self,
@ClosureParams(FirstParam.Component.cla
return count(Arrays.asList(self), closure);
}
- /**
- * Counts the number of occurrences of the given value inside this array.
- * Comparison is done using Groovy's == operator (using
- * <code>compareTo(value) == 0</code> or <code>equals(value)</code> ).
- *
- * @param self the array within which we count the number of occurrences
- * @param value the value being searched for
- * @return the number of occurrences
- * @since 1.6.4
- */
+ @Deprecated
public static Number count(int[] self, Object value) {
- return count(InvokerHelper.asIterator(self), value);
+ return ArrayGroovyMethods.count(self, value);
}
- /**
- * Counts the number of occurrences of the given value inside this array.
- * Comparison is done using Groovy's == operator (using
- * <code>compareTo(value) == 0</code> or <code>equals(value)</code> ).
- *
- * @param self the array within which we count the number of occurrences
- * @param value the value being searched for
- * @return the number of occurrences
- * @since 1.6.4
- */
+ @Deprecated
public static Number count(long[] self, Object value) {
- return count(InvokerHelper.asIterator(self), value);
+ return ArrayGroovyMethods.count(self, value);
}
- /**
- * Counts the number of occurrences of the given value inside this array.
- * Comparison is done using Groovy's == operator (using
- * <code>compareTo(value) == 0</code> or <code>equals(value)</code> ).
- *
- * @param self the array within which we count the number of occurrences
- * @param value the value being searched for
- * @return the number of occurrences
- * @since 1.6.4
- */
+ @Deprecated
public static Number count(short[] self, Object value) {
- return count(InvokerHelper.asIterator(self), value);
+ return ArrayGroovyMethods.count(self, value);
}
- /**
- * Counts the number of occurrences of the given value inside this array.
- * Comparison is done using Groovy's == operator (using
- * <code>compareTo(value) == 0</code> or <code>equals(value)</code> ).
- *
- * @param self the array within which we count the number of occurrences
- * @param value the value being searched for
- * @return the number of occurrences
- * @since 1.6.4
- */
+ @Deprecated
public static Number count(char[] self, Object value) {
- return count(InvokerHelper.asIterator(self), value);
+ return ArrayGroovyMethods.count(self, value);
}
- /**
- * Counts the number of occurrences of the given value inside this array.
- * Comparison is done using Groovy's == operator (using
- * <code>compareTo(value) == 0</code> or <code>equals(value)</code> ).
- *
- * @param self the array within which we count the number of occurrences
- * @param value the value being searched for
- * @return the number of occurrences
- * @since 1.6.4
- */
+ @Deprecated
public static Number count(boolean[] self, Object value) {
- return count(InvokerHelper.asIterator(self), value);
+ return ArrayGroovyMethods.count(self, value);
}
- /**
- * Counts the number of occurrences of the given value inside this array.
- * Comparison is done using Groovy's == operator (using
- * <code>compareTo(value) == 0</code> or <code>equals(value)</code> ).
- *
- * @param self the array within which we count the number of occurrences
- * @param value the value being searched for
- * @return the number of occurrences
- * @since 1.6.4
- */
+ @Deprecated
public static Number count(double[] self, Object value) {
- return count(InvokerHelper.asIterator(self), value);
+ return ArrayGroovyMethods.count(self, value);
}
- /**
- * Counts the number of occurrences of the given value inside this array.
- * Comparison is done using Groovy's == operator (using
- * <code>compareTo(value) == 0</code> or <code>equals(value)</code> ).
- *
- * @param self the array within which we count the number of occurrences
- * @param value the value being searched for
- * @return the number of occurrences
- * @since 1.6.4
- */
+ @Deprecated
public static Number count(float[] self, Object value) {
Review Comment:
*[InlineMeSuggester](https://errorprone.info/bugpattern/InlineMeSuggester):*
This deprecated API looks inlineable. If you'd like the body of the API to be
inlined to its callers, please annotate it with @InlineMe.
---
```suggestion
@InlineMe(replacement = "ArrayGroovyMethods.count(self, value)", imports
= "org.codehaus.groovy.runtime.ArrayGroovyMethods")
```
---
<details><summary><b>âšī¸ Learn about @sonatype-lift commands</b></summary>
You can reply with the following commands. For example, reply with
***@sonatype-lift ignoreall*** to leave out all findings.
| **Command** | **Usage** |
| ------------- | ------------- |
| `@sonatype-lift ignore` | Leave out the above finding from this PR |
| `@sonatype-lift ignoreall` | Leave out all the existing findings from this
PR |
| `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified
`file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
**Note:** When talking to LiftBot, you need to **refresh** the page to see
its response.
<sub>[Click here](https://github.com/apps/sonatype-lift/installations/new)
to add LiftBot to another repo.</sub></details>
---
Was this a good recommendation?
[ [đ Not
relevant](https://www.sonatype.com/lift-comment-rating?comment=340737698&lift_comment_rating=1)
] - [ [đ Won't
fix](https://www.sonatype.com/lift-comment-rating?comment=340737698&lift_comment_rating=2)
] - [ [đ Not critical, will
fix](https://www.sonatype.com/lift-comment-rating?comment=340737698&lift_comment_rating=3)
] - [ [đ Critical, will
fix](https://www.sonatype.com/lift-comment-rating?comment=340737698&lift_comment_rating=4)
] - [ [đ Critical, fixing
now](https://www.sonatype.com/lift-comment-rating?comment=340737698&lift_comment_rating=5)
]
##########
src/main/java/org/codehaus/groovy/runtime/DefaultGroovyMethods.java:
##########
@@ -7549,84 +7195,44 @@ public static <T> IntRange getIndices(T[] self) {
return new IntRange(false, 0, self.length);
}
- /**
- * Returns indices of the boolean array.
- *
- * @see #getIndices(Object[])
- * @since 3.0.8
- */
+ @Deprecated
public static IntRange getIndices(boolean[] self) {
- return new IntRange(false, 0, self.length);
+ return ArrayGroovyMethods.getIndices(self);
}
- /**
- * Returns indices of the byte array.
- *
- * @see #getIndices(Object[])
- * @since 3.0.8
- */
+ @Deprecated
public static IntRange getIndices(byte[] self) {
- return new IntRange(false, 0, self.length);
+ return ArrayGroovyMethods.getIndices(self);
}
- /**
- * Returns indices of the char array.
- *
- * @see #getIndices(Object[])
- * @since 3.0.8
- */
+ @Deprecated
public static IntRange getIndices(char[] self) {
- return new IntRange(false, 0, self.length);
+ return ArrayGroovyMethods.getIndices(self);
}
- /**
- * Returns indices of the double array.
- *
- * @see #getIndices(Object[])
- * @since 3.0.8
- */
+ @Deprecated
public static IntRange getIndices(double[] self) {
Review Comment:
*[InlineMeSuggester](https://errorprone.info/bugpattern/InlineMeSuggester):*
This deprecated API looks inlineable. If you'd like the body of the API to be
inlined to its callers, please annotate it with @InlineMe.
---
```suggestion
@InlineMe(replacement = "ArrayGroovyMethods.getIndices(self)", imports =
"org.codehaus.groovy.runtime.ArrayGroovyMethods")
```
---
<details><summary><b>âšī¸ Learn about @sonatype-lift commands</b></summary>
You can reply with the following commands. For example, reply with
***@sonatype-lift ignoreall*** to leave out all findings.
| **Command** | **Usage** |
| ------------- | ------------- |
| `@sonatype-lift ignore` | Leave out the above finding from this PR |
| `@sonatype-lift ignoreall` | Leave out all the existing findings from this
PR |
| `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified
`file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
**Note:** When talking to LiftBot, you need to **refresh** the page to see
its response.
<sub>[Click here](https://github.com/apps/sonatype-lift/installations/new)
to add LiftBot to another repo.</sub></details>
---
Was this a good recommendation?
[ [đ Not
relevant](https://www.sonatype.com/lift-comment-rating?comment=340737703&lift_comment_rating=1)
] - [ [đ Won't
fix](https://www.sonatype.com/lift-comment-rating?comment=340737703&lift_comment_rating=2)
] - [ [đ Not critical, will
fix](https://www.sonatype.com/lift-comment-rating?comment=340737703&lift_comment_rating=3)
] - [ [đ Critical, will
fix](https://www.sonatype.com/lift-comment-rating?comment=340737703&lift_comment_rating=4)
] - [ [đ Critical, fixing
now](https://www.sonatype.com/lift-comment-rating?comment=340737703&lift_comment_rating=5)
]
##########
src/main/java/org/codehaus/groovy/runtime/DefaultGroovyMethods.java:
##########
@@ -6567,112 +6363,34 @@ public static Object average(Iterator<?> self) {
return result;
}
- /**
- * Calculates the average of the bytes in the array.
- * <pre class="groovyTestCase">assert 5.0G == ([2,4,6,8] as
byte[]).average()</pre>
- *
- * @param self The array of values to calculate the average of
- * @return The average of the items
- * @since 3.0.0
- */
+ @Deprecated
public static BigDecimal average(byte[] self) {
- long s = 0;
- int count = 0;
- for (byte v : self) {
- s += v;
- count++;
- }
- return BigDecimal.valueOf(s).divide(BigDecimal.valueOf(count));
+ return ArrayGroovyMethods.average(self);
}
- /**
- * Calculates the average of the shorts in the array.
- * <pre class="groovyTestCase">assert 5.0G == ([2,4,6,8] as
short[]).average()</pre>
- *
- * @param self The array of values to calculate the average of
- * @return The average of the items
- * @since 3.0.0
- */
+ @Deprecated
public static BigDecimal average(short[] self) {
- long s = 0;
- int count = 0;
- for (short v : self) {
- s += v;
- count++;
- }
- return BigDecimal.valueOf(s).divide(BigDecimal.valueOf(count));
+ return ArrayGroovyMethods.average(self);
}
- /**
- * Calculates the average of the ints in the array.
- * <pre class="groovyTestCase">assert 5.0G == ([2,4,6,8] as
int[]).average()</pre>
- *
- * @param self The array of values to calculate the average of
- * @return The average of the items
- * @since 3.0.0
- */
+ @Deprecated
public static BigDecimal average(int[] self) {
- long s = 0;
- int count = 0;
- for (int v : self) {
- s += v;
- count++;
- }
- return BigDecimal.valueOf(s).divide(BigDecimal.valueOf(count));
+ return ArrayGroovyMethods.average(self);
}
- /**
- * Calculates the average of the longs in the array.
- * <pre class="groovyTestCase">assert 5.0G == ([2,4,6,8] as
long[]).average()</pre>
- *
- * @param self The array of values to calculate the average of
- * @return The average of the items
- * @since 3.0.0
- */
+ @Deprecated
public static BigDecimal average(long[] self) {
Review Comment:
*[InlineMeSuggester](https://errorprone.info/bugpattern/InlineMeSuggester):*
This deprecated API looks inlineable. If you'd like the body of the API to be
inlined to its callers, please annotate it with @InlineMe.
---
```suggestion
@InlineMe(replacement = "ArrayGroovyMethods.average(self)", imports =
"org.codehaus.groovy.runtime.ArrayGroovyMethods")
```
---
<details><summary><b>âšī¸ Learn about @sonatype-lift commands</b></summary>
You can reply with the following commands. For example, reply with
***@sonatype-lift ignoreall*** to leave out all findings.
| **Command** | **Usage** |
| ------------- | ------------- |
| `@sonatype-lift ignore` | Leave out the above finding from this PR |
| `@sonatype-lift ignoreall` | Leave out all the existing findings from this
PR |
| `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified
`file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
**Note:** When talking to LiftBot, you need to **refresh** the page to see
its response.
<sub>[Click here](https://github.com/apps/sonatype-lift/installations/new)
to add LiftBot to another repo.</sub></details>
---
Was this a good recommendation?
[ [đ Not
relevant](https://www.sonatype.com/lift-comment-rating?comment=340737706&lift_comment_rating=1)
] - [ [đ Won't
fix](https://www.sonatype.com/lift-comment-rating?comment=340737706&lift_comment_rating=2)
] - [ [đ Not critical, will
fix](https://www.sonatype.com/lift-comment-rating?comment=340737706&lift_comment_rating=3)
] - [ [đ Critical, will
fix](https://www.sonatype.com/lift-comment-rating?comment=340737706&lift_comment_rating=4)
] - [ [đ Critical, fixing
now](https://www.sonatype.com/lift-comment-rating?comment=340737706&lift_comment_rating=5)
]
##########
src/main/java/org/codehaus/groovy/runtime/DefaultGroovyMethods.java:
##########
@@ -6103,88 +6032,39 @@ public static Object sum(Iterator<Object> self) {
return sum(self, null, true);
}
- /**
- * Sums the items in an array.
- * <pre class="groovyTestCase">assert (1+2+3+4 as byte) == ([1,2,3,4] as
byte[]).sum()</pre>
- *
- * @param self The array of values to add together
- * @return The sum of all of the items
- * @since 2.4.2
- */
+ @Deprecated
public static byte sum(byte[] self) {
- return sum(self, (byte) 0);
+ return ArrayGroovyMethods.sum(self);
}
- /**
- * Sums the items in an array.
- * <pre class="groovyTestCase">assert (1+2+3+4 as short) == ([1,2,3,4] as
short[]).sum()</pre>
- *
- * @param self The array of values to add together
- * @return The sum of all of the items
- * @since 2.4.2
- */
+ @Deprecated
public static short sum(short[] self) {
- return sum(self, (short) 0);
+ return ArrayGroovyMethods.sum(self);
}
- /**
- * Sums the items in an array.
- * <pre class="groovyTestCase">assert 1+2+3+4 == ([1,2,3,4] as
int[]).sum()</pre>
- *
- * @param self The array of values to add together
- * @return The sum of all of the items
- * @since 2.4.2
- */
+ @Deprecated
public static int sum(int[] self) {
- return sum(self, 0);
+ return ArrayGroovyMethods.sum(self);
}
- /**
- * Sums the items in an array.
- * <pre class="groovyTestCase">assert (1+2+3+4 as long) == ([1,2,3,4] as
long[]).sum()</pre>
- *
- * @param self The array of values to add together
- * @return The sum of all of the items
- * @since 2.4.2
- */
+ @Deprecated
public static long sum(long[] self) {
- return sum(self, 0);
+ return ArrayGroovyMethods.sum(self);
}
- /**
- * Sums the items in an array.
- * <pre class="groovyTestCase">assert (1+2+3+4 as char) == ([1,2,3,4] as
char[]).sum()</pre>
- *
- * @param self The array of values to add together
- * @return The sum of all of the items
- * @since 2.4.2
- */
+ @Deprecated
public static char sum(char[] self) {
- return sum(self, (char) 0);
+ return ArrayGroovyMethods.sum(self);
}
- /**
- * Sums the items in an array.
- * <pre class="groovyTestCase">assert (1+2+3+4 as float) == ([1,2,3,4] as
float[]).sum()</pre>
- *
- * @param self The array of values to add together
- * @return The sum of all of the items
- * @since 2.4.2
- */
+ @Deprecated
public static float sum(float[] self) {
Review Comment:
*[InlineMeSuggester](https://errorprone.info/bugpattern/InlineMeSuggester):*
This deprecated API looks inlineable. If you'd like the body of the API to be
inlined to its callers, please annotate it with @InlineMe.
---
```suggestion
@InlineMe(replacement = "ArrayGroovyMethods.sum(self)", imports =
"org.codehaus.groovy.runtime.ArrayGroovyMethods")
```
---
<details><summary><b>âšī¸ Learn about @sonatype-lift commands</b></summary>
You can reply with the following commands. For example, reply with
***@sonatype-lift ignoreall*** to leave out all findings.
| **Command** | **Usage** |
| ------------- | ------------- |
| `@sonatype-lift ignore` | Leave out the above finding from this PR |
| `@sonatype-lift ignoreall` | Leave out all the existing findings from this
PR |
| `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified
`file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
**Note:** When talking to LiftBot, you need to **refresh** the page to see
its response.
<sub>[Click here](https://github.com/apps/sonatype-lift/installations/new)
to add LiftBot to another repo.</sub></details>
---
Was this a good recommendation?
[ [đ Not
relevant](https://www.sonatype.com/lift-comment-rating?comment=340737732&lift_comment_rating=1)
] - [ [đ Won't
fix](https://www.sonatype.com/lift-comment-rating?comment=340737732&lift_comment_rating=2)
] - [ [đ Not critical, will
fix](https://www.sonatype.com/lift-comment-rating?comment=340737732&lift_comment_rating=3)
] - [ [đ Critical, will
fix](https://www.sonatype.com/lift-comment-rating?comment=340737732&lift_comment_rating=4)
] - [ [đ Critical, fixing
now](https://www.sonatype.com/lift-comment-rating?comment=340737732&lift_comment_rating=5)
]
##########
src/main/java/org/codehaus/groovy/runtime/DefaultGroovyMethods.java:
##########
@@ -6103,88 +6032,39 @@ public static Object sum(Iterator<Object> self) {
return sum(self, null, true);
}
- /**
- * Sums the items in an array.
- * <pre class="groovyTestCase">assert (1+2+3+4 as byte) == ([1,2,3,4] as
byte[]).sum()</pre>
- *
- * @param self The array of values to add together
- * @return The sum of all of the items
- * @since 2.4.2
- */
+ @Deprecated
public static byte sum(byte[] self) {
- return sum(self, (byte) 0);
+ return ArrayGroovyMethods.sum(self);
}
- /**
- * Sums the items in an array.
- * <pre class="groovyTestCase">assert (1+2+3+4 as short) == ([1,2,3,4] as
short[]).sum()</pre>
- *
- * @param self The array of values to add together
- * @return The sum of all of the items
- * @since 2.4.2
- */
+ @Deprecated
public static short sum(short[] self) {
Review Comment:
*[InlineMeSuggester](https://errorprone.info/bugpattern/InlineMeSuggester):*
This deprecated API looks inlineable. If you'd like the body of the API to be
inlined to its callers, please annotate it with @InlineMe.
---
```suggestion
@InlineMe(replacement = "ArrayGroovyMethods.sum(self)", imports =
"org.codehaus.groovy.runtime.ArrayGroovyMethods")
```
---
<details><summary><b>âšī¸ Learn about @sonatype-lift commands</b></summary>
You can reply with the following commands. For example, reply with
***@sonatype-lift ignoreall*** to leave out all findings.
| **Command** | **Usage** |
| ------------- | ------------- |
| `@sonatype-lift ignore` | Leave out the above finding from this PR |
| `@sonatype-lift ignoreall` | Leave out all the existing findings from this
PR |
| `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified
`file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
**Note:** When talking to LiftBot, you need to **refresh** the page to see
its response.
<sub>[Click here](https://github.com/apps/sonatype-lift/installations/new)
to add LiftBot to another repo.</sub></details>
---
Was this a good recommendation?
[ [đ Not
relevant](https://www.sonatype.com/lift-comment-rating?comment=340737749&lift_comment_rating=1)
] - [ [đ Won't
fix](https://www.sonatype.com/lift-comment-rating?comment=340737749&lift_comment_rating=2)
] - [ [đ Not critical, will
fix](https://www.sonatype.com/lift-comment-rating?comment=340737749&lift_comment_rating=3)
] - [ [đ Critical, will
fix](https://www.sonatype.com/lift-comment-rating?comment=340737749&lift_comment_rating=4)
] - [ [đ Critical, fixing
now](https://www.sonatype.com/lift-comment-rating?comment=340737749&lift_comment_rating=5)
]
##########
src/main/java/org/codehaus/groovy/runtime/DefaultGroovyMethods.java:
##########
@@ -6567,112 +6363,34 @@ public static Object average(Iterator<?> self) {
return result;
}
- /**
- * Calculates the average of the bytes in the array.
- * <pre class="groovyTestCase">assert 5.0G == ([2,4,6,8] as
byte[]).average()</pre>
- *
- * @param self The array of values to calculate the average of
- * @return The average of the items
- * @since 3.0.0
- */
+ @Deprecated
public static BigDecimal average(byte[] self) {
- long s = 0;
- int count = 0;
- for (byte v : self) {
- s += v;
- count++;
- }
- return BigDecimal.valueOf(s).divide(BigDecimal.valueOf(count));
+ return ArrayGroovyMethods.average(self);
}
- /**
- * Calculates the average of the shorts in the array.
- * <pre class="groovyTestCase">assert 5.0G == ([2,4,6,8] as
short[]).average()</pre>
- *
- * @param self The array of values to calculate the average of
- * @return The average of the items
- * @since 3.0.0
- */
+ @Deprecated
public static BigDecimal average(short[] self) {
- long s = 0;
- int count = 0;
- for (short v : self) {
- s += v;
- count++;
- }
- return BigDecimal.valueOf(s).divide(BigDecimal.valueOf(count));
+ return ArrayGroovyMethods.average(self);
}
- /**
- * Calculates the average of the ints in the array.
- * <pre class="groovyTestCase">assert 5.0G == ([2,4,6,8] as
int[]).average()</pre>
- *
- * @param self The array of values to calculate the average of
- * @return The average of the items
- * @since 3.0.0
- */
+ @Deprecated
public static BigDecimal average(int[] self) {
Review Comment:
*[InlineMeSuggester](https://errorprone.info/bugpattern/InlineMeSuggester):*
This deprecated API looks inlineable. If you'd like the body of the API to be
inlined to its callers, please annotate it with @InlineMe.
---
```suggestion
@InlineMe(replacement = "ArrayGroovyMethods.average(self)", imports =
"org.codehaus.groovy.runtime.ArrayGroovyMethods")
```
---
<details><summary><b>âšī¸ Learn about @sonatype-lift commands</b></summary>
You can reply with the following commands. For example, reply with
***@sonatype-lift ignoreall*** to leave out all findings.
| **Command** | **Usage** |
| ------------- | ------------- |
| `@sonatype-lift ignore` | Leave out the above finding from this PR |
| `@sonatype-lift ignoreall` | Leave out all the existing findings from this
PR |
| `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified
`file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
**Note:** When talking to LiftBot, you need to **refresh** the page to see
its response.
<sub>[Click here](https://github.com/apps/sonatype-lift/installations/new)
to add LiftBot to another repo.</sub></details>
---
Was this a good recommendation?
[ [đ Not
relevant](https://www.sonatype.com/lift-comment-rating?comment=340737766&lift_comment_rating=1)
] - [ [đ Won't
fix](https://www.sonatype.com/lift-comment-rating?comment=340737766&lift_comment_rating=2)
] - [ [đ Not critical, will
fix](https://www.sonatype.com/lift-comment-rating?comment=340737766&lift_comment_rating=3)
] - [ [đ Critical, will
fix](https://www.sonatype.com/lift-comment-rating?comment=340737766&lift_comment_rating=4)
] - [ [đ Critical, fixing
now](https://www.sonatype.com/lift-comment-rating?comment=340737766&lift_comment_rating=5)
]
##########
src/main/java/org/codehaus/groovy/runtime/DefaultGroovyMethods.java:
##########
@@ -11693,108 +11299,44 @@ public static boolean asBoolean(Object[] array) {
return array != null && array.length > 0;
}
- /**
- * Coerces a byte array to a boolean value.
- * A byte array is false if the array is of length 0,
- * and true otherwise.
- *
- * @param array an array
- * @return the array's boolean value
- * @since 1.7.4
- */
+ @Deprecated
public static boolean asBoolean(byte[] array) {
- return array != null && array.length > 0;
+ return ArrayGroovyMethods.asBoolean(array);
}
- /**
- * Coerces a short array to a boolean value.
- * A short array is false if the array is of length 0,
- * and true otherwise.
- *
- * @param array an array
- * @return the array's boolean value
- * @since 1.7.4
- */
+ @Deprecated
public static boolean asBoolean(short[] array) {
- return array != null && array.length > 0;
+ return ArrayGroovyMethods.asBoolean(array);
}
- /**
- * Coerces an int array to a boolean value.
- * An int array is false if the array is of length 0,
- * and true otherwise.
- *
- * @param array an array
- * @return the array's boolean value
- * @since 1.7.4
- */
+ @Deprecated
public static boolean asBoolean(int[] array) {
Review Comment:
*[InlineMeSuggester](https://errorprone.info/bugpattern/InlineMeSuggester):*
This deprecated API looks inlineable. If you'd like the body of the API to be
inlined to its callers, please annotate it with @InlineMe.
---
```suggestion
@InlineMe(replacement = "ArrayGroovyMethods.asBoolean(array)", imports =
"org.codehaus.groovy.runtime.ArrayGroovyMethods")
```
---
<details><summary><b>âšī¸ Learn about @sonatype-lift commands</b></summary>
You can reply with the following commands. For example, reply with
***@sonatype-lift ignoreall*** to leave out all findings.
| **Command** | **Usage** |
| ------------- | ------------- |
| `@sonatype-lift ignore` | Leave out the above finding from this PR |
| `@sonatype-lift ignoreall` | Leave out all the existing findings from this
PR |
| `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified
`file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
**Note:** When talking to LiftBot, you need to **refresh** the page to see
its response.
<sub>[Click here](https://github.com/apps/sonatype-lift/installations/new)
to add LiftBot to another repo.</sub></details>
---
Was this a good recommendation?
[ [đ Not
relevant](https://www.sonatype.com/lift-comment-rating?comment=340737773&lift_comment_rating=1)
] - [ [đ Won't
fix](https://www.sonatype.com/lift-comment-rating?comment=340737773&lift_comment_rating=2)
] - [ [đ Not critical, will
fix](https://www.sonatype.com/lift-comment-rating?comment=340737773&lift_comment_rating=3)
] - [ [đ Critical, will
fix](https://www.sonatype.com/lift-comment-rating?comment=340737773&lift_comment_rating=4)
] - [ [đ Critical, fixing
now](https://www.sonatype.com/lift-comment-rating?comment=340737773&lift_comment_rating=5)
]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
