sonatype-lift[bot] commented on code in PR #1785:
URL: https://github.com/apache/groovy/pull/1785#discussion_r984915395
##########
src/main/java/org/codehaus/groovy/runtime/DefaultGroovyMethods.java:
##########
@@ -6803,116 +6521,44 @@ public static <T> String join(T[] self, String
separator) {
return join(new ArrayIterator<>(self), separator);
}
- /**
- * Concatenates the string representation of each
- * items in this array, with the given String as a separator between each
- * item.
- *
- * @param self an array of boolean
- * @param separator a String separator
- * @return the joined String
- * @since 2.4.1
- */
+ @Deprecated
public static String join(boolean[] self, String separator) {
- return join(new BooleanArrayIterator(self), separator);
+ return ArrayGroovyMethods.join(self, separator);
}
- /**
- * Concatenates the string representation of each
- * items in this array, with the given String as a separator between each
- * item.
- *
- * @param self an array of byte
- * @param separator a String separator
- * @return the joined String
- * @since 2.4.1
- */
+ @Deprecated
public static String join(byte[] self, String separator) {
- return join(new ByteArrayIterator(self), separator);
+ return ArrayGroovyMethods.join(self, separator);
}
- /**
- * Concatenates the string representation of each
- * items in this array, with the given String as a separator between each
- * item.
- *
- * @param self an array of char
- * @param separator a String separator
- * @return the joined String
- * @since 2.4.1
- */
+ @Deprecated
public static String join(char[] self, String separator) {
- return join(new CharArrayIterator(self), separator);
+ return ArrayGroovyMethods.join(self, separator);
}
- /**
- * Concatenates the string representation of each
- * items in this array, with the given String as a separator between each
- * item.
- *
- * @param self an array of double
- * @param separator a String separator
- * @return the joined String
- * @since 2.4.1
- */
+ @Deprecated
public static String join(double[] self, String separator) {
Review Comment:
*[InlineMeSuggester](https://errorprone.info/bugpattern/InlineMeSuggester):*
This deprecated API looks inlineable. If you'd like the body of the API to be
inlined to its callers, please annotate it with @InlineMe.
---
```suggestion
@InlineMe(replacement = "ArrayGroovyMethods.join(self, separator)",
imports = "org.codehaus.groovy.runtime.ArrayGroovyMethods")
```
---
<details><summary><b>âšī¸ Learn about @sonatype-lift commands</b></summary>
You can reply with the following commands. For example, reply with
***@sonatype-lift ignoreall*** to leave out all findings.
| **Command** | **Usage** |
| ------------- | ------------- |
| `@sonatype-lift ignore` | Leave out the above finding from this PR |
| `@sonatype-lift ignoreall` | Leave out all the existing findings from this
PR |
| `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified
`file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
**Note:** When talking to LiftBot, you need to **refresh** the page to see
its response.
<sub>[Click here](https://github.com/apps/sonatype-lift/installations/new)
to add LiftBot to another repo.</sub></details>
---
Was this a good recommendation?
[ [đ Not
relevant](https://www.sonatype.com/lift-comment-rating?comment=340737779&lift_comment_rating=1)
] - [ [đ Won't
fix](https://www.sonatype.com/lift-comment-rating?comment=340737779&lift_comment_rating=2)
] - [ [đ Not critical, will
fix](https://www.sonatype.com/lift-comment-rating?comment=340737779&lift_comment_rating=3)
] - [ [đ Critical, will
fix](https://www.sonatype.com/lift-comment-rating?comment=340737779&lift_comment_rating=4)
] - [ [đ Critical, fixing
now](https://www.sonatype.com/lift-comment-rating?comment=340737779&lift_comment_rating=5)
]
##########
src/main/java/org/codehaus/groovy/runtime/DefaultGroovyMethods.java:
##########
@@ -6803,116 +6521,44 @@ public static <T> String join(T[] self, String
separator) {
return join(new ArrayIterator<>(self), separator);
}
- /**
- * Concatenates the string representation of each
- * items in this array, with the given String as a separator between each
- * item.
- *
- * @param self an array of boolean
- * @param separator a String separator
- * @return the joined String
- * @since 2.4.1
- */
+ @Deprecated
public static String join(boolean[] self, String separator) {
- return join(new BooleanArrayIterator(self), separator);
+ return ArrayGroovyMethods.join(self, separator);
}
- /**
- * Concatenates the string representation of each
- * items in this array, with the given String as a separator between each
- * item.
- *
- * @param self an array of byte
- * @param separator a String separator
- * @return the joined String
- * @since 2.4.1
- */
+ @Deprecated
public static String join(byte[] self, String separator) {
- return join(new ByteArrayIterator(self), separator);
+ return ArrayGroovyMethods.join(self, separator);
}
- /**
- * Concatenates the string representation of each
- * items in this array, with the given String as a separator between each
- * item.
- *
- * @param self an array of char
- * @param separator a String separator
- * @return the joined String
- * @since 2.4.1
- */
+ @Deprecated
public static String join(char[] self, String separator) {
- return join(new CharArrayIterator(self), separator);
+ return ArrayGroovyMethods.join(self, separator);
}
- /**
- * Concatenates the string representation of each
- * items in this array, with the given String as a separator between each
- * item.
- *
- * @param self an array of double
- * @param separator a String separator
- * @return the joined String
- * @since 2.4.1
- */
+ @Deprecated
public static String join(double[] self, String separator) {
- return join(new DoubleArrayIterator(self), separator);
+ return ArrayGroovyMethods.join(self, separator);
}
- /**
- * Concatenates the string representation of each
- * items in this array, with the given String as a separator between each
- * item.
- *
- * @param self an array of float
- * @param separator a String separator
- * @return the joined String
- * @since 2.4.1
- */
+ @Deprecated
public static String join(float[] self, String separator) {
- return join(new FloatArrayIterator(self), separator);
+ return ArrayGroovyMethods.join(self, separator);
}
- /**
- * Concatenates the string representation of each
- * items in this array, with the given String as a separator between each
- * item.
- *
- * @param self an array of int
- * @param separator a String separator
- * @return the joined String
- * @since 2.4.1
- */
+ @Deprecated
public static String join(int[] self, String separator) {
Review Comment:
*[InlineMeSuggester](https://errorprone.info/bugpattern/InlineMeSuggester):*
This deprecated API looks inlineable. If you'd like the body of the API to be
inlined to its callers, please annotate it with @InlineMe.
---
```suggestion
@InlineMe(replacement = "ArrayGroovyMethods.join(self, separator)",
imports = "org.codehaus.groovy.runtime.ArrayGroovyMethods")
```
---
<details><summary><b>âšī¸ Learn about @sonatype-lift commands</b></summary>
You can reply with the following commands. For example, reply with
***@sonatype-lift ignoreall*** to leave out all findings.
| **Command** | **Usage** |
| ------------- | ------------- |
| `@sonatype-lift ignore` | Leave out the above finding from this PR |
| `@sonatype-lift ignoreall` | Leave out all the existing findings from this
PR |
| `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified
`file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
**Note:** When talking to LiftBot, you need to **refresh** the page to see
its response.
<sub>[Click here](https://github.com/apps/sonatype-lift/installations/new)
to add LiftBot to another repo.</sub></details>
---
Was this a good recommendation?
[ [đ Not
relevant](https://www.sonatype.com/lift-comment-rating?comment=340737790&lift_comment_rating=1)
] - [ [đ Won't
fix](https://www.sonatype.com/lift-comment-rating?comment=340737790&lift_comment_rating=2)
] - [ [đ Not critical, will
fix](https://www.sonatype.com/lift-comment-rating?comment=340737790&lift_comment_rating=3)
] - [ [đ Critical, will
fix](https://www.sonatype.com/lift-comment-rating?comment=340737790&lift_comment_rating=4)
] - [ [đ Critical, fixing
now](https://www.sonatype.com/lift-comment-rating?comment=340737790&lift_comment_rating=5)
]
##########
src/main/java/org/codehaus/groovy/runtime/DefaultGroovyMethods.java:
##########
@@ -7549,84 +7195,44 @@ public static <T> IntRange getIndices(T[] self) {
return new IntRange(false, 0, self.length);
}
- /**
- * Returns indices of the boolean array.
- *
- * @see #getIndices(Object[])
- * @since 3.0.8
- */
+ @Deprecated
public static IntRange getIndices(boolean[] self) {
- return new IntRange(false, 0, self.length);
+ return ArrayGroovyMethods.getIndices(self);
}
- /**
- * Returns indices of the byte array.
- *
- * @see #getIndices(Object[])
- * @since 3.0.8
- */
+ @Deprecated
public static IntRange getIndices(byte[] self) {
- return new IntRange(false, 0, self.length);
+ return ArrayGroovyMethods.getIndices(self);
}
- /**
- * Returns indices of the char array.
- *
- * @see #getIndices(Object[])
- * @since 3.0.8
- */
+ @Deprecated
public static IntRange getIndices(char[] self) {
- return new IntRange(false, 0, self.length);
+ return ArrayGroovyMethods.getIndices(self);
}
- /**
- * Returns indices of the double array.
- *
- * @see #getIndices(Object[])
- * @since 3.0.8
- */
+ @Deprecated
public static IntRange getIndices(double[] self) {
- return new IntRange(false, 0, self.length);
+ return ArrayGroovyMethods.getIndices(self);
}
- /**
- * Returns indices of the float array.
- *
- * @see #getIndices(Object[])
- * @since 3.0.8
- */
+ @Deprecated
public static IntRange getIndices(float[] self) {
- return new IntRange(false, 0, self.length);
+ return ArrayGroovyMethods.getIndices(self);
}
- /**
- * Returns indices of the int array.
- *
- * @see #getIndices(Object[])
- * @since 3.0.8
- */
+ @Deprecated
public static IntRange getIndices(int[] self) {
- return new IntRange(false, 0, self.length);
+ return ArrayGroovyMethods.getIndices(self);
}
- /**
- * Returns indices of the long array.
- *
- * @see #getIndices(Object[])
- * @since 3.0.8
- */
+ @Deprecated
public static IntRange getIndices(long[] self) {
- return new IntRange(false, 0, self.length);
+ return ArrayGroovyMethods.getIndices(self);
}
- /**
- * Returns indices of the short array.
- *
- * @see #getIndices(Object[])
- * @since 3.0.8
- */
+ @Deprecated
public static IntRange getIndices(short[] self) {
Review Comment:
*[InlineMeSuggester](https://errorprone.info/bugpattern/InlineMeSuggester):*
This deprecated API looks inlineable. If you'd like the body of the API to be
inlined to its callers, please annotate it with @InlineMe.
---
```suggestion
@InlineMe(replacement = "ArrayGroovyMethods.getIndices(self)", imports =
"org.codehaus.groovy.runtime.ArrayGroovyMethods")
```
---
<details><summary><b>âšī¸ Learn about @sonatype-lift commands</b></summary>
You can reply with the following commands. For example, reply with
***@sonatype-lift ignoreall*** to leave out all findings.
| **Command** | **Usage** |
| ------------- | ------------- |
| `@sonatype-lift ignore` | Leave out the above finding from this PR |
| `@sonatype-lift ignoreall` | Leave out all the existing findings from this
PR |
| `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified
`file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
**Note:** When talking to LiftBot, you need to **refresh** the page to see
its response.
<sub>[Click here](https://github.com/apps/sonatype-lift/installations/new)
to add LiftBot to another repo.</sub></details>
---
Was this a good recommendation?
[ [đ Not
relevant](https://www.sonatype.com/lift-comment-rating?comment=340737805&lift_comment_rating=1)
] - [ [đ Won't
fix](https://www.sonatype.com/lift-comment-rating?comment=340737805&lift_comment_rating=2)
] - [ [đ Not critical, will
fix](https://www.sonatype.com/lift-comment-rating?comment=340737805&lift_comment_rating=3)
] - [ [đ Critical, will
fix](https://www.sonatype.com/lift-comment-rating?comment=340737805&lift_comment_rating=4)
] - [ [đ Critical, fixing
now](https://www.sonatype.com/lift-comment-rating?comment=340737805&lift_comment_rating=5)
]
##########
src/main/java/org/codehaus/groovy/runtime/DefaultGroovyMethods.java:
##########
@@ -6803,116 +6521,44 @@ public static <T> String join(T[] self, String
separator) {
return join(new ArrayIterator<>(self), separator);
}
- /**
- * Concatenates the string representation of each
- * items in this array, with the given String as a separator between each
- * item.
- *
- * @param self an array of boolean
- * @param separator a String separator
- * @return the joined String
- * @since 2.4.1
- */
+ @Deprecated
public static String join(boolean[] self, String separator) {
- return join(new BooleanArrayIterator(self), separator);
+ return ArrayGroovyMethods.join(self, separator);
}
- /**
- * Concatenates the string representation of each
- * items in this array, with the given String as a separator between each
- * item.
- *
- * @param self an array of byte
- * @param separator a String separator
- * @return the joined String
- * @since 2.4.1
- */
+ @Deprecated
public static String join(byte[] self, String separator) {
Review Comment:
*[InlineMeSuggester](https://errorprone.info/bugpattern/InlineMeSuggester):*
This deprecated API looks inlineable. If you'd like the body of the API to be
inlined to its callers, please annotate it with @InlineMe.
---
```suggestion
@InlineMe(replacement = "ArrayGroovyMethods.join(self, separator)",
imports = "org.codehaus.groovy.runtime.ArrayGroovyMethods")
```
---
<details><summary><b>âšī¸ Learn about @sonatype-lift commands</b></summary>
You can reply with the following commands. For example, reply with
***@sonatype-lift ignoreall*** to leave out all findings.
| **Command** | **Usage** |
| ------------- | ------------- |
| `@sonatype-lift ignore` | Leave out the above finding from this PR |
| `@sonatype-lift ignoreall` | Leave out all the existing findings from this
PR |
| `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified
`file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
**Note:** When talking to LiftBot, you need to **refresh** the page to see
its response.
<sub>[Click here](https://github.com/apps/sonatype-lift/installations/new)
to add LiftBot to another repo.</sub></details>
---
Was this a good recommendation?
[ [đ Not
relevant](https://www.sonatype.com/lift-comment-rating?comment=340737835&lift_comment_rating=1)
] - [ [đ Won't
fix](https://www.sonatype.com/lift-comment-rating?comment=340737835&lift_comment_rating=2)
] - [ [đ Not critical, will
fix](https://www.sonatype.com/lift-comment-rating?comment=340737835&lift_comment_rating=3)
] - [ [đ Critical, will
fix](https://www.sonatype.com/lift-comment-rating?comment=340737835&lift_comment_rating=4)
] - [ [đ Critical, fixing
now](https://www.sonatype.com/lift-comment-rating?comment=340737835&lift_comment_rating=5)
]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
