[ 
https://issues.apache.org/jira/browse/GROOVY-10925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17685247#comment-17685247
 ] 

Paul King commented on GROOVY-10925:
------------------------------------

Yes, we have some inconsistent behavior. There has been debate in the past.

The semantics for properties with an initializer is to treat them like defaults 
on the constructors.
{code:java}
@TupleConstructor
class C {
  final one = 1
  def two = 2
}
{code}
basically being equivalent to:
{code:java}
class C {
  private final one
  private two
  C(one = 1, two = 2) {
    this.one = one
    this.two = two
  }
  def getOne() { one }
  def getTwo() { two }
  void setTwo(two) { this.two = two }
}
{code}
I think the same concept can be carried over to the map constructor but there 
are some inconsistencies and issues with fields currently.

I'll have a further look shortly.

> @TupleConstructor namedVariant breaks on setting private final fields in 
> constructor
> ------------------------------------------------------------------------------------
>
>                 Key: GROOVY-10925
>                 URL: https://issues.apache.org/jira/browse/GROOVY-10925
>             Project: Groovy
>          Issue Type: Bug
>    Affects Versions: 4.0.8
>            Reporter: Joe Li
>            Priority: Major
>
> @TupleConstructor `namedVariant` Breaks in Groovy4 when setting values to 
> private final fields in constructor
>  
> Example code in Groovy4 that throws the `Unrecognized namedArgKey: x` error:
> {code:java}
> import groovy.transform.*
> @TupleConstructor(includeFields = true, namedVariant = true)
> @ToString(includeNames = true, includeFields = true)
> class Foo {    
>   private final int x = 1   
>   private int y = 2    
>   private final int z
> }
> println new Foo(x:3, y: 3, z: 3) {code}
>  
>  
> After removing the `namedVariant` and add the `@MapConstructor` the code 
> works:
> {code:java}
> import groovy.transform.*
> @MapConstructor(includeFields = true)
> @TupleConstructor(includeFields = true)
> @ToString(includeNames = true, includeFields = true)
> class Foo {    
>   private final int x = 1   
>   private int y = 2    
>   private final int z
> }
> println new Foo(x:3, y: 3, z: 3) {code}
>  
>  
> Related issue: 
> [GROOVY-10919|https://issues.apache.org/jira/browse/GROOVY-10919], 
> @MapConstructor Breaks in Groovy4 when combined with @TupleConstructor, fine 
> in Groovy3



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to