blackdrag commented on PR #2352: URL: https://github.com/apache/groovy/pull/2352#issuecomment-3641294794
Frankly the general Writable-concept has its problems. I was fixing the issue in GROOVY-8373 only. If you look at: - https://github.com/apache/groovy/blob/2d9c467ade68da0e3e73e64c4db7f29d742162f9/src/main/org/codehaus/groovy/runtime/IOGroovyMethods.java#L1450 - https://github.com/apache/groovy/blob/2d9c467ade68da0e3e73e64c4db7f29d742162f9/src/main/org/codehaus/groovy/runtime/IOGroovyMethods.java#L1490 then you have one readline that closes the writer, while the other returns a writer, which you are, I guess, supposed to reuse. And in that manner it would be wrong to have it closed in the method I changed. But does the API make sense like this? Well, not part of the issue as I said ;) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
