eric-milles commented on PR #2352: URL: https://github.com/apache/groovy/pull/2352#issuecomment-3642519223
The `void filterLine(Reader,Writer,...` variant explicitly states that it closes the reader and writer. https://github.com/apache/groovy/blob/f3b6fdd794171fe8992b4024f881dec1c974f97a/src/main/java/org/codehaus/groovy/runtime/IOGroovyMethods.java#L1450 The `Writable filterLine(Reader,...)` variant does not say this. Maybe it is enough to add a comment saying reader is not closed. The internal `BufferedReader` only maintains a reference to the input reader and a char array. The array will be GC'd when no references to the Writable AIC remain. Is that not sufficient? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
