[
https://issues.apache.org/jira/browse/GROOVY-12035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18083028#comment-18083028
] ASF GitHub Bot commented on GROOVY-12035: ----------------------------------------- codecov-commenter commented on PR #2556: URL: https://github.com/apache/groovy/pull/2556#issuecomment-4524610685 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2556?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 68.1887%. Comparing base ([`5318145`](https://app.codecov.io/gh/apache/groovy/commit/53181454e08716af1fb76927215775fb75084f56?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`924789f`](https://app.codecov.io/gh/apache/groovy/commit/924789f6864ec89fa0062095817c09cebff7cacf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 5 commits behind head on master. <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2556?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2556 +/- ## ================================================== + Coverage 68.1844% 68.1887% +0.0043% - Complexity 33086 33096 +10 ================================================== Files 1508 1508 Lines 126130 126147 +17 Branches 22878 22887 +9 ================================================== + Hits 86001 86018 +17 - Misses 32490 32491 +1 + Partials 7639 7638 -1 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2556?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../codehaus/groovy/classgen/asm/StatementWriter.java](https://app.codecov.io/gh/apache/groovy/pull/2556?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fclassgen%2Fasm%2FStatementWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2NsYXNzZ2VuL2FzbS9TdGF0ZW1lbnRXcml0ZXIuamF2YQ==) | `96.9310% <100.0000%> (+0.0079%)` | :arrow_up: | ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2556/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > Avoid emitting unreachable GOTO in if/else bytecode generation > -------------------------------------------------------------- > > Key: GROOVY-12035 > URL: https://issues.apache.org/jira/browse/GROOVY-12035 > Project: Groovy > Issue Type: Improvement > Reporter: Daniel Sun > Priority: Major > > StatementWriter.writeIfElse currently emits GOTO exitPath unconditionally > whenever an else branch exists. If the if branch is already non-fallthrough > (e.g., return, throw, or nested abrupt control flow), that jump is > unreachable and introduces dead bytecode in the generated method. -- This message was sent by Atlassian Jira (v8.20.10#820010)
