[jira] [Commented] (GROOVY-12035) Avoid emitting unreachable GOTO in if/else bytecode generation

[ASF GitHub Bot (Jira)]

    [ 
https://issues.apache.org/jira/browse/GROOVY-12035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18083035#comment-18083035
 ] 

ASF GitHub Bot commented on GROOVY-12035:
-----------------------------------------

testlens-app[bot] commented on PR #2556:
URL: https://github.com/apache/groovy/pull/2556#issuecomment-4524794764

   ## 🚨 TestLens detected 1 failed test 🚨
   
   Here is what you can do:
   
   1) Inspect the test failures carefully.
   2) If you are convinced that some of the tests are flaky, you can mute them 
below.
   3) Finally, trigger a rerun by checking the rerun checkbox.
   
   ### Test Summary
   
   | Check | Project/Task | Test | Runs |
   |---|---|---|---|
   | [Build and test / lts \(17, 
ubuntu-latest\)](https://github.com/apache/groovy/actions/runs/26327793537/job/77508521228?pr=2556)
 | :groovy-groovysh:test | HelpCommandTest > helpListsKnownCommands\(\) | ❌ |
   
   🏷️ Commit: 797b02206ff43f623b016097d906e7acff34a905
   ▶️ Tests:  37027 executed
   🟡 Checks: 9/57 completed
   
   ### Test Failures
   
   <details>
   
   <summary><strong>HelpCommandTest > helpListsKnownCommands()</strong> 
(:groovy-groovysh:test in <a 
href="https://github.com/apache/groovy/actions/runs/26327793537/job/77508521228?pr=2556";>Build
 and test / lts (17, ubuntu-latest)</a>)</summary>
   
   ```
   Assertion failed: 
   
   assert !out.empty
          ||   |
          |''  true
          false
   
        at 
org.codehaus.groovy.runtime.InvokerHelper.createAssertError(InvokerHelper.java:400)
        at 
org.apache.groovy.groovysh.commands.HelpCommandTest.helpListsKnownCommands(HelpCommandTest.groovy:39)
   ```
   
   </details>
   
   ### Muted Tests
   > [!NOTE]
   > Checks are currently running using the configuration below.
   
   Select tests to mute in this pull request:
   
   🔲 HelpCommandTest > helpListsKnownCommands\(\) <!

> Avoid emitting unreachable GOTO in if/else bytecode generation
> --------------------------------------------------------------
>
>                 Key: GROOVY-12035
>                 URL: https://issues.apache.org/jira/browse/GROOVY-12035
>             Project: Groovy
>          Issue Type: Improvement
>            Reporter: Daniel Sun
>            Priority: Major
>
> StatementWriter.writeIfElse currently emits GOTO exitPath unconditionally 
> whenever an else branch exists. If the if branch is already non-fallthrough 
> (e.g., return, throw, or nested abrupt control flow), that jump is 
> unreachable and introduces dead bytecode in the generated method.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)