[
https://issues.apache.org/jira/browse/GROOVY-11521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18133855#comment-18133855
] ASF GitHub Bot commented on GROOVY-11521: ----------------------------------------- codecov-commenter commented on PR #3074: URL: https://github.com/apache/groovy/pull/3074#issuecomment-6482316739 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/3074?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `75.40984%` with `15 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 73.6258%. Comparing base ([`cfd9b2f`](https://app.codecov.io/gh/apache/groovy/commit/cfd9b2f0222a8e1a74473f7c5b2cb45b5bdd3b5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd1835b`](https://app.codecov.io/gh/apache/groovy/commit/fd1835b81851f0210764b985bf568deb5caaae9d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 9 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/3074?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...a/org/codehaus/groovy/ast/tools/GenericsUtils.java](https://app.codecov.io/gh/apache/groovy/pull/3074?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fast%2Ftools%2FGenericsUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2FzdC90b29scy9HZW5lcmljc1V0aWxzLmphdmE=) | 75.4098% | [8 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/groovy/pull/3074?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/3074?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #3074 +/- ## ================================================== + Coverage 73.6047% 73.6258% +0.0210% + Complexity 42348 42196 -152 ================================================== Files 1657 1658 +1 Lines 145708 145938 +230 Branches 27498 27529 +31 ================================================== + Hits 107248 107448 +200 - Misses 28479 28498 +19 - Partials 9981 9992 +11 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/3074?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...a/org/codehaus/groovy/ast/tools/GenericsUtils.java](https://app.codecov.io/gh/apache/groovy/pull/3074?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fast%2Ftools%2FGenericsUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2FzdC90b29scy9HZW5lcmljc1V0aWxzLmphdmE=) | `70.0855% <75.4098%> (+0.2673%)` | :arrow_up: | ... and [24 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/3074/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > GenericsUtils parameterizeType fails to propagate wildcard generics > ------------------------------------------------------------------- > > Key: GROOVY-11521 > URL: https://issues.apache.org/jira/browse/GROOVY-11521 > Project: Groovy > Issue Type: Bug > Reporter: Eric Milles > Assignee: Daniel Sun > Priority: Major > > Given a class node like "java.util.ArrayList<? extends java.lang.Number>", > calling {{GenericsUtils.parameterizeType(arrayList, list)}} produces > "java.util.List<java.lang.Number>". The wildcard has been lost. > This method is used in STC and elsewhere. > GROOVY-8084, GROOVY-9074, GROOVY-9891 -- This message was sent by Atlassian Jira (v10.3.26#10030026)
