[jira] [Commented] (GROOVY-12573) LogTest loses its spy handler when the logger is garbage collected before the class under test logs

[ASF GitHub Bot (Jira)]

    [ 
https://issues.apache.org/jira/browse/GROOVY-12573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18134539#comment-18134539
 ] 

ASF GitHub Bot commented on GROOVY-12573:
-----------------------------------------

codecov-commenter commented on PR #3101:
URL: https://github.com/apache/groovy/pull/3101#issuecomment-6512253448

   ## 
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/3101?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 73.6722%. Comparing base 
([`5b077f9`](https://app.codecov.io/gh/apache/groovy/commit/5b077f9dcf610898e3415f1f1cebbaab8eecab61?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
 to head 
([`76046e8`](https://app.codecov.io/gh/apache/groovy/commit/76046e8dc8d29ce03a06f7ec7e19f59cd1b9ea6c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 4 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   [![Impacted file tree 
graph](https://app.codecov.io/gh/apache/groovy/pull/3101/graphs/tree.svg?width=650&height=150&src=pr&token=1r45138NfQ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)](https://app.codecov.io/gh/apache/groovy/pull/3101?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   ```diff
   @@                Coverage Diff                 @@
   ##               master      #3101        +/-   ##
   ==================================================
   + Coverage     73.6711%   73.6722%   +0.0011%     
     Complexity      42584      42584                
   ==================================================
     Files            1678       1678                
     Lines          146907     146913         +6     
     Branches        27790      27792         +2     
   ==================================================
   + Hits           108228     108234         +6     
   + Misses          28528      28527         -1     
   - Partials        10151      10152         +1     
   ```
   [see 14 files with indirect coverage 
changes](https://app.codecov.io/gh/apache/groovy/pull/3101/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test 
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, 
report on failures, and find test suite problems.
   - :package: [JS Bundle 
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save 
yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>




> LogTest loses its spy handler when the logger is garbage collected before the 
> class under test logs
> ---------------------------------------------------------------------------------------------------
>
>                 Key: GROOVY-12573
>                 URL: https://issues.apache.org/jira/browse/GROOVY-12573
>             Project: Groovy
>          Issue Type: Test
>            Reporter: Scott Murphy Heiberg
>            Priority: Major
>
> {{LogTest.registerLogFormatterSpy}} adds a handler to 
> {{Logger.getLogger(name)}} without keeping the logger. The {{LogManager}} 
> holds loggers weakly, so a garbage collection before the class under test 
> initializes drops the logger, and the class gets a new one without the spy; 
> {{testDefaultCategory}} then fails (seen on CI).
> PR: https://github.com/apache/groovy/pull/3101



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)