[jira] [Commented] (GROOVY-12573) LogTest loses its spy handler when the logger is garbage collected before the class under test logs

[ASF GitHub Bot (Jira) via notifications]

    [ 
https://issues.apache.org/jira/browse/GROOVY-12573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18135615#comment-18135615
 ] 

ASF GitHub Bot commented on GROOVY-12573:
-----------------------------------------

testlens-app[bot] commented on PR #3101:
URL: https://github.com/apache/groovy/pull/3101#issuecomment-6539776780

   ## 🚨 All tests passed but jobs failed 🚨
   
   ### Failed Jobs without Test Failures
   
   ❌ [Build and test / lts \(17, 
macos-latest\)](https://github.com/apache/groovy/actions/runs/41169515604/job/124444227166?pr=3101)
   ❌ [Build and test / lts \(17, 
ubuntu-latest\)](https://github.com/apache/groovy/actions/runs/41169515604/job/124444227128?pr=3101)
   ❌ [Build and test / lts \(17, windows-latest, 
1\)](https://github.com/apache/groovy/actions/runs/41169515604/job/124444227193?pr=3101)
   ❌ [Build and test / lts \(25, 
ubuntu-latest\)](https://github.com/apache/groovy/actions/runs/41169515604/job/124444227251?pr=3101)
   
   🏷️ Commit: c5a1a2fc705fbfcc785080c57293260ddf6ac4d0
   ▶️ Tests:  44504 executed
   ⚪️ Checks: 26/26 completed
   
   ### Rerun Controls
   
   Click the checkbox to trigger a rerun:
   
   - [ ] **Rerun jobs**
   
   ---
   _Learn more about TestLens at 
[testlens.app/docs](https://testlens.app/docs/features/pr-comment/)._
   




> LogTest loses its spy handler when the logger is garbage collected before the 
> class under test logs
> ---------------------------------------------------------------------------------------------------
>
>                 Key: GROOVY-12573
>                 URL: https://issues.apache.org/jira/browse/GROOVY-12573
>             Project: Groovy
>          Issue Type: Test
>            Reporter: Scott Murphy Heiberg
>            Priority: Major
>
> {{LogTest.registerLogFormatterSpy}} adds a handler to 
> {{Logger.getLogger(name)}} without keeping the logger. The {{LogManager}} 
> holds loggers weakly, so a garbage collection before the class under test 
> initializes drops the logger, and the class gets a new one without the spy; 
> {{testDefaultCategory}} then fails (seen on CI).
> PR: https://github.com/apache/groovy/pull/3101



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)