[
https://issues.apache.org/jira/browse/GROOVY-12568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18135505#comment-18135505
]
ASF GitHub Bot commented on GROOVY-12568:
-----------------------------------------
codeconsole commented on PR #3097:
URL: https://github.com/apache/groovy/pull/3097#issuecomment-6536942328
@blackdrag Simplified in e9c86b5dfc:
```java
if (field.isPublic() || field.isPrivate()) { // nestmates can access a
private field
return isMemberDirectlyAccessible(field.getModifiers(), declaringClass,
accessingClass);
}
// JVMS 5.4.4
return isInSameRuntimePackage(declaringClass, accessingClass)
|| (field.isProtected() && accessingClass.isDerivedFrom(declaringClass));
```
- Public and private fields: the language rule decides; the run-time package
does not matter for them, and a private field is reachable only from nestmates,
which are compiled together.
- Protected and package-private fields: JVMS 5.4.4 allows access from the
run-time package of the declaring class (package name plus defining loader),
and to a protected field from a subclass. `isMemberDirectlyAccessible` also
accepts any class with the same package name, which is the excluded case: a
class compiled earlier by another `GroovyClassLoader` compilation has the same
package name but another loader, and `GETFIELD` of its field fails with
`IllegalAccessError`. For these fields the JVM condition implies
`isMemberDirectlyAccessible` (same run-time package implies same package name),
so it replaces that call instead of being checked after it. Same shape as
`StaticInvocationWriter.isDirectlyAccessible(ConstructorNode)`.
- Both parts are needed: checking the package name instead of
`isInSameRuntimePackage` fails the 5 field tests of
`StaticCompileRuntimePackageTest`; dropping the subclass part fails
`FieldsAndPropertiesStaticCompileTest.testReadFieldFromSuperClass2/3`,
`MethodReferenceTest.testInnerClassProtectedMethodReference` and
`StaticCompileRuntimePackageTest.testProtectedFieldOfSuperclassOfAnotherClassLoaderIsAccessedDirectly`.
The result is the same as before for every field, so no test changed. Also
merged master now that #3022 has landed, so this PR shows only GROOVY-12568.
`MethodReferenceTest.testMethodReferencesInStaticAndDefaultMethodsOfInterface`
fails on master itself since #3056; #3116 fixes it.
> SC: protected and package-private members of a class defined by another
> GroovyClassLoader compilation fail with IllegalAccessError
> ----------------------------------------------------------------------------------------------------------------------------------
>
> Key: GROOVY-12568
> URL: https://issues.apache.org/jira/browse/GROOVY-12568
> Project: Groovy
> Issue Type: Bug
> Components: Static compilation
> Affects Versions: 6.0.0
> Reporter: Scott Murphy Heiberg
> Priority: Major
>
> The JVM allows access to a protected or package-private member only within
> the same run-time package, which is the package name and the class loader. A
> {{GroovyClassLoader}} defines each compilation in memory with a class loader
> of its own: a {{GroovyShell}} script, {{parseClass}}, a script run with
> {{groovy}}, JSR-223. So a class of an earlier parse, or a precompiled class
> used by such a script, is in another run-time package even with the same
> package name. Statically compiled code calls such members directly and fails;
> dynamic code goes through the meta-class and works.
> {code:groovy}
> def shell = new GroovyShell()
> shell.evaluate '''package p
> class A {
> @groovy.transform.PackageScope A(String s) { }
> @groovy.transform.PackageScope String name() { 'a' }
> @groovy.transform.PackageScope String tag = 't'
> }
> true
> '''
> shell.evaluate '''package p
> @groovy.transform.CompileStatic
> List make() { def a = new A('x'); [a.name(), a.tag] }
> make()
> ''' // IllegalAccessError; without @CompileStatic: ['a', 't']
> {code}
> The same happens for map-style construction, instance and static methods,
> getters and setters used as properties, method references such as
> {{a::name}}, and field reads and writes including {{.@}}, {{+=}} and {{++}}.
> In dynamic code, {{super.f}}, {{super.@f}} and {{this.@f}} of such a field,
> and {{super.m()}} of such a method, fail the same way, because the {{super$}}
> helper and the field instructions are generated directly.
> Related, in a subclass in another package, under static compilation:
> * {{new A(...)}} of a protected constructor of another package compiles and
> then fails verification. As in Java, only {{super(...)}} and {{new A(...)
> {}}} can call it.
> * a protected method of another package called through a receiver of the
> superclass type ({{a.m()}}, {{a.name}}, {{a::m}}, {{A::m}}) compiles and then
> fails with {{VerifyError}}: the GROOVY-7325 check compared the types the
> wrong way round. {{a.@field = value}} through such a receiver fails
> verification too.
> * with invokedynamic, a dynamic {{new ObjectInputStream()}} in a subclass
> fails with {{GroovyBugError}} ("member is protected") instead of "could not
> access constructor".
> Expected: such members are reached through the meta-class, as in dynamic
> code; code compiled to class files (groovyc, Gradle, Maven, joint
> compilation) keeps direct access, as javac does; the two verification
> failures are compile errors.
> PR: https://github.com/apache/groovy/pull/3097
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
