[
https://issues.apache.org/jira/browse/GROOVY-12568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18135938#comment-18135938
]
ASF GitHub Bot commented on GROOVY-12568:
-----------------------------------------
codeconsole commented on PR #3097:
URL: https://github.com/apache/groovy/pull/3097#issuecomment-6549370768
@blackdrag I see the conflict. For the same failure, `IllegalAccessError` at
run time, #3019 reports a compile error and this PR quietly goes dynamic.
What this PR does now:
- **Already in line with #3019.** These cases are rejected at compile time,
as Java rejects them: `new A(...)` of a protected constructor of another
package, and a protected method of another package called through a superclass
receiver.
- **The part that conflicts.** A protected or package-private member of a
class that has the same package name but was defined by another
`GroovyClassLoader` compilation (a class from an earlier `GroovyShell` parse,
for example). JLS 6.6 counts it as accessible, so #3019's `hasAccessToClass`
accepts it. The JVM refuses it, so this PR routes the access through the
meta-class. #3098 does the same for a package-private class from another
loader, and #3099 for `super.m()`.
The alternative in line with #3019: the type checker treats such a member or
class as inaccessible and reports "Cannot access ...". This applies to
`@CompileStatic` and `@TypeChecked`, while dynamic code keeps working. The
compiler knows the case for certain, because the class comes from a loader
other than the in-memory compilation's. Code compiled to class files is
unaffected, as now. Either way it is no regression: today such code compiles
and then fails with `IllegalAccessError`. The writer changes that route
accesses through the meta-class (constructors, methods, method-reference
helpers, fields) would be dropped, which makes the PR much smaller.
If that is what you mean, I'll rework #3097 this way, and #3098 and #3099
with it. I also merged master in (93d57765fa); `Groovy12484` and this PR's
tests pass together.
> SC: protected and package-private members of a class defined by another
> GroovyClassLoader compilation fail with IllegalAccessError
> ----------------------------------------------------------------------------------------------------------------------------------
>
> Key: GROOVY-12568
> URL: https://issues.apache.org/jira/browse/GROOVY-12568
> Project: Groovy
> Issue Type: Bug
> Components: Static compilation
> Affects Versions: 6.0.0
> Reporter: Scott Murphy Heiberg
> Priority: Major
>
> The JVM allows access to a protected or package-private member only within
> the same run-time package, which is the package name and the class loader. A
> {{GroovyClassLoader}} defines each compilation in memory with a class loader
> of its own: a {{GroovyShell}} script, {{parseClass}}, a script run with
> {{groovy}}, JSR-223. So a class of an earlier parse, or a precompiled class
> used by such a script, is in another run-time package even with the same
> package name. Statically compiled code calls such members directly and fails;
> dynamic code goes through the meta-class and works.
> {code:groovy}
> def shell = new GroovyShell()
> shell.evaluate '''package p
> class A {
> @groovy.transform.PackageScope A(String s) { }
> @groovy.transform.PackageScope String name() { 'a' }
> @groovy.transform.PackageScope String tag = 't'
> }
> true
> '''
> shell.evaluate '''package p
> @groovy.transform.CompileStatic
> List make() { def a = new A('x'); [a.name(), a.tag] }
> make()
> ''' // IllegalAccessError; without @CompileStatic: ['a', 't']
> {code}
> The same happens for map-style construction, instance and static methods,
> getters and setters used as properties, method references such as
> {{a::name}}, and field reads and writes including {{.@}}, {{+=}} and {{++}}.
> In dynamic code, {{super.f}}, {{super.@f}} and {{this.@f}} of such a field,
> and {{super.m()}} of such a method, fail the same way, because the {{super$}}
> helper and the field instructions are generated directly.
> Related, in a subclass in another package, under static compilation:
> * {{new A(...)}} of a protected constructor of another package compiles and
> then fails verification. As in Java, only {{super(...)}} and {{new A(...)
> {}}} can call it.
> * a protected method of another package called through a receiver of the
> superclass type ({{a.m()}}, {{a.name}}, {{a::m}}, {{A::m}}) compiles and then
> fails with {{VerifyError}}: the GROOVY-7325 check compared the types the
> wrong way round. {{a.@field = value}} through such a receiver fails
> verification too.
> * with invokedynamic, a dynamic {{new ObjectInputStream()}} in a subclass
> fails with {{GroovyBugError}} ("member is protected") instead of "could not
> access constructor".
> Expected: such members are reached through the meta-class, as in dynamic
> code; code compiled to class files (groovyc, Gradle, Maven, joint
> compilation) keeps direct access, as javac does; the two verification
> failures are compile errors.
> PR: https://github.com/apache/groovy/pull/3097
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
