harshith1118 commented on PR #1402: URL: https://github.com/apache/hamilton/pull/1402#issuecomment-3375122315
Thanks for the feedback! On Tue, 7 Oct 2025 at 09:39, Stefan Krawczyk ***@***.***> wrote: > *skrawcz* left a comment (apache/hamilton#1402) > <https://github.com/apache/hamilton/pull/1402#issuecomment-3375119859> > > Hi *skrawcz* , I've verified the content of the pyproject.toml file in > the current repository, and I can confirm that tomli is indeed correctly > included in the cli dependencies section as shown below: File: > pyproject.toml Lines: 56-59 cli = [ "typer", "tomli", ] The CLI > dependencies do NOT contain loguru, click, and requests as you mentioned. > My contribution has been properly implemented with tomli added to the > appropriate cli section alongside typer. It's possible you might be > looking at an older version of the code, a different branch, or there may > have been some confusion. The current state clearly shows that tomli is > in the correct location within the optional dependencies. Thanks, Harshith D > … <#m_9180364118654577230_> > On Mon, Oct 6, 2025, 10:37 PM Stefan Krawczyk *@*.*> wrote: skrawcz left > a comment (apache/hamilton#1402 > <https://github.com/apache/hamilton/pull/1402>) <#1402 (comment) > <https://github.com/apache/hamilton/pull/1402#issuecomment-3372881025>> > @harshith1118 <https://github.com/harshith1118> > https://github.com/harshith1118 <https://github.com/harshith1118> it is not > in there: cli = [ "loguru", "click", "requests" ] — Reply to this email > directly, view it on GitHub <#1402 (comment) > <https://github.com/apache/hamilton/pull/1402#issuecomment-3372881025>>, or > unsubscribe > https://github.com/notifications/unsubscribe-auth/BAIHD2EYLDRUMJIB7KFQK233WKOUPAVCNFSM6AAAAACIILXX6GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGNZSHA4DCMBSGU > <https://github.com/notifications/unsubscribe-auth/BAIHD2EYLDRUMJIB7KFQK233WKOUPAVCNFSM6AAAAACIILXX6GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGNZSHA4DCMBSGU> > . You are receiving this because you were mentioned.Message ID: @.*> > > 🤦 😮💨 -- sorry you are right. It is in there. I was looking at another > pyproject.toml that I have open in my hamilton project. Sorry! This looks > great. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/hamilton/pull/1402#issuecomment-3375119859>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/BAIHD2HWMXEXTQCO5WSR7D33WM4JHAVCNFSM6AAAAACIILXX6GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGNZVGEYTSOBVHE> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
