harshith1118 commented on PR #1402:
URL: https://github.com/apache/hamilton/pull/1402#issuecomment-3370063263
First Issue Response:
Regarding the import tomli statement that "doesn't seem useful" - I
removed the debug file (debug_toml.py)
that contained this unnecessary import. The file was just loading a file
without purpose, so it has been
completely removed from the codebase as requested.
Second Issue Response:
Regarding the version in docs/how-tos/cli-reference.md that said "Starting
with version 2.0.0" - this has
been correctly updated to "Starting with version 1.90.0" to reflect when
the feature will actually be
released.
Third & Fourth Issue Response:
Regarding the tomli import in hamilton/cli/logic.py and the dependency - I
can confirm that tomli is
already properly declared in pyproject.toml under the
[project.optional-dependencies] -> cli section as
"tomli". The import inside the function is done correctly with proper
error handling, so no additional
changes were needed.
Last Issue Response:
The debug file has been removed and the tomli dependency was already
present in pyproject.toml. All
changes have been committed and pushed to the repository successfully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
