skrawcz commented on code in PR #1444:
URL: https://github.com/apache/hamilton/pull/1444#discussion_r2705597900
##########
hamilton/plugins/pandas_extensions.py:
##########
@@ -205,14 +206,15 @@ def _get_loading_kwargs(self) -> Dict[str, Any]:
kwargs["keep_default_na"] = self.keep_default_na
if self.na_filter is not None:
kwargs["na_filter"] = self.na_filter
- if self.verbose is not None:
- kwargs["verbose"] = self.verbose
if self.skip_blank_lines is not None:
kwargs["skip_blank_lines"] = self.skip_blank_lines
if self.parse_dates is not None:
kwargs["parse_dates"] = self.parse_dates
- if self.keep_date_col is not None:
- kwargs["keep_date_col"] = self.keep_date_col
+ if pandas_version < Version("2.0"):
Review Comment:
rather than having this appear in the middle of the kwargs, how about we
move this to the end so it's clear here are all the <2.0 kwargs -- it'll be
clearer when reading the code that way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
