AvinashYerra commented on code in PR #1444:
URL: https://github.com/apache/hamilton/pull/1444#discussion_r2706005614
##########
hamilton/plugins/pandas_extensions.py:
##########
@@ -257,7 +257,12 @@ def _get_loading_kwargs(self) -> Dict[str, Any]:
kwargs["float_precision"] = self.float_precision
if self.storage_options is not None:
kwargs["storage_options"] = self.storage_options
- if pd.__version__ >= "2.0" and self.dtype_backend is not None:
+ if self.delim_whitespace is not None:
+ if pandas_version < Version("2.0"):
+ kwargs["delim_whitespace"] = self.delim_whitespace
+ elif self.delim_whitespace:
+ kwargs.setdefault("sep", r"\s+")
Review Comment:
yeah, checked it now. There is a separate "if" section for "sep". I think we
can safely remove the default setting "elif" statement.
Done the changes addressing the same. you can review it now.
thanks @skrawcz
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
