tomsun28 commented on code in PR #2070:
URL: https://github.com/apache/hertzbeat/pull/2070#discussion_r1650775090
##########
alerter/src/main/java/org/apache/hertzbeat/alert/reduce/AlarmConvergeReduce.java:
##########
@@ -55,25 +55,33 @@ public AlarmConvergeReduce(AlertConvergeDao
alertConvergeDao) {
@SuppressWarnings("unchecked")
public boolean filterConverge(Alert currentAlert) {
// ignore monitor status auto recover notice
- if (currentAlert.getTags() != null &&
currentAlert.getTags().containsKey(CommonConstants.IGNORE)) {
- return true;
- }
- if (currentAlert.getStatus() ==
CommonConstants.ALERT_STATUS_CODE_RESTORED) {
+ if ((currentAlert.getTags() != null &&
currentAlert.getTags().containsKey(CommonConstants.IGNORE))
+ || currentAlert.getStatus() ==
CommonConstants.ALERT_STATUS_CODE_RESTORED) {
Review Comment:
```suggestion
if (currentAlert.getStatus() ==
CommonConstants.ALERT_STATUS_CODE_RESTORED) {
```
status always is the ALERT_STATUS_CODE_RESTORED when tags has
CommonConstants.IGNORE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
