Yanshuming1 commented on code in PR #2070:
URL: https://github.com/apache/hertzbeat/pull/2070#discussion_r1651062350
##########
alerter/src/main/java/org/apache/hertzbeat/alert/reduce/AlarmConvergeReduce.java:
##########
@@ -55,25 +55,33 @@ public AlarmConvergeReduce(AlertConvergeDao
alertConvergeDao) {
@SuppressWarnings("unchecked")
public boolean filterConverge(Alert currentAlert) {
// ignore monitor status auto recover notice
- if (currentAlert.getTags() != null &&
currentAlert.getTags().containsKey(CommonConstants.IGNORE)) {
- return true;
- }
- if (currentAlert.getStatus() ==
CommonConstants.ALERT_STATUS_CODE_RESTORED) {
+ if ((currentAlert.getTags() != null &&
currentAlert.getTags().containsKey(CommonConstants.IGNORE))
+ || currentAlert.getStatus() ==
CommonConstants.ALERT_STATUS_CODE_RESTORED) {
Review Comment:
In both cases, the data in the map needs to be deleted，if remove （||
currentAlert . getStatus () == CommonConstants . ALERT_STATUS_CODE_RESTORED
），So when the label is not IGNORE，Unable to clear cache
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
