tomsun28 commented on code in PR #2376:
URL: https://github.com/apache/hertzbeat/pull/2376#discussion_r1694048985
##########
collector/src/main/java/org/apache/hertzbeat/collector/collect/common/ssh/CommonSshClient.java:
##########
@@ -43,7 +43,7 @@ public class CommonSshClient {
PropertyResolverUtils.updateProperty(
SSH_CLIENT, CoreModuleProperties.HEARTBEAT_INTERVAL.getName(),
2000);
PropertyResolverUtils.updateProperty(
- SSH_CLIENT,
CoreModuleProperties.HEARTBEAT_REPLY_WAIT.getName(), 300_000);
+ SSH_CLIENT,
CoreModuleProperties.HEARTBEAT_NO_REPLY_MAX.getName(), 300_000);
Review Comment:
hi the HEARTBEAT_REPLY_WAIT HEARTBEAT_NO_REPLY_MAX seem value is different.
it seems HEARTBEAT_REPLY_WAIT is time, HEARTBEAT_NO_REPLY_MAX is times.
/**
* Key used to indicate that the heartbeat request is also expecting a
reply - time in <U>milliseconds</U> to wait
* for the reply. If non-positive then no reply is expected (nor
requested).
*
* @deprecated since 2.13.0, use {@link #HEARTBEAT_NO_REPLY_MAX} instead
*/
@Deprecated
public static final Property<Duration> HEARTBEAT_REPLY_WAIT
= Property.durationSec("heartbeat-reply-wait",
Duration.ofMinutes(5));
/**
* Key to set the maximum number of heartbeat messages to send without
having received a reply. If > 0, heartbeat
* messages are sent with a flag that requires the peer to reply. The
session will be killed if
* {@code HEARTBEAT_NO_REPLY_MAX} heartbeats have been sent without
having received a reply. If <= 0, heartbeat
* messages will be sent, but no reply is requested or expected, and the
client will not kill the session.
*
* @since 2.13.0
*/
public static final Property<Integer> HEARTBEAT_NO_REPLY_MAX =
Property.integer("heartbeat-no-reply-max", 0);
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
