tomsun28 commented on code in PR #2376:
URL: https://github.com/apache/hertzbeat/pull/2376#discussion_r1694216567
##########
collector/src/main/java/org/apache/hertzbeat/collector/collect/common/ssh/CommonSshClient.java:
##########
@@ -43,7 +43,7 @@ public class CommonSshClient {
PropertyResolverUtils.updateProperty(
SSH_CLIENT, CoreModuleProperties.HEARTBEAT_INTERVAL.getName(),
2000);
PropertyResolverUtils.updateProperty(
- SSH_CLIENT,
CoreModuleProperties.HEARTBEAT_REPLY_WAIT.getName(), 300_000);
+ SSH_CLIENT,
CoreModuleProperties.HEARTBEAT_NO_REPLY_MAX.getName(), 300_000);
Review Comment:
hi the note it suggest use HEARTBEAT_NO_REPLY_MAX instead of
Deprecated-HEARTBEAT_REPLY_WAIT. How about we set the right
HEARTBEAT_NO_REPLY_MAX value for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]