wilmerdooley opened a new pull request, #4154: URL: https://github.com/apache/hertzbeat/pull/4154
## What's changed? Removed the synchronous `detectMonitor` invocation from the `modifyMonitor` flow in `MonitorServiceImpl`. Previously, updating a monitor's settings (such as the collect interval) would trigger an immediate detection pass while still holding the monitor lock, which could block the request for a long time and eventually cause the API to time out even though the save itself succeeded. The detection is no longer required as part of the update path; the collector will pick up the new configuration on its next scheduled run. This makes the `modify monitor` endpoint return promptly and prevents the misleading timeout-on-successful-save behavior reported by users. Resolves #3812 ## Checklist - [x] I have read the [Contributing Guide](https://hertzbeat.apache.org/docs/community/code_style_and_quality_guide) - [ ] I have written the necessary doc or comment. - [ ] I have added the necessary unit tests and all cases have passed. ## Add or update API - [ ] I have added the necessary [e2e tests](https://github.com/apache/hertzbeat/tree/master/e2e) and all cases have passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
