wilmerdooley commented on PR #4154: URL: https://github.com/apache/hertzbeat/pull/4154#issuecomment-4699826376
Thanks again for the catch. One note on the behavior tradeoff with this approach: dropping the synchronous detect means the status now reflects the last value the real-time collection path wrote and reconverges on the next collect cycle, rather than being re-measured on the spot at edit time. If keeping that instant post-edit refresh matters here, I would be glad to move the detect off the request thread and run it asynchronously instead, which would still keep this preserve line so the save does not race it. Otherwise the preserve-only fix as pushed keeps the status correct, and I am happy to take the async direction if it fits the project better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
