zqr10159 commented on PR #4371: URL: https://github.com/apache/hertzbeat/pull/4371#issuecomment-5908342554
Thanks for adding the missing help pages. I checked the Sentinel parameter table against app-redis_sentinel.yml and RedisCommonCollectImpl. Please correct these in both the English and Chinese pages: 1. Line 19 describes Pattern as an optional regular expression for filtering INFO output. The template defines a required numeric mode with default 2, and the collector uses it to choose the connection mode, not as a regex filter. Please describe it as the internal Sentinel mode/default, or omit it from the user-facing parameter table since it is hidden. 2. Line 23 lists the SSH timeout default as 60000 ms, but the template sets sshTimeout to 6000 ms. Please align the documentation with that default. After updating, please validate the documentation build and the English/Chinese help links. DOC CI and the license workflow are currently awaiting maintainer approval, so there is no CI build result yet. These findings are from source comparison; I have not run the site locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
