zqr10159 commented on PR #4371: URL: https://github.com/apache/hertzbeat/pull/4371#issuecomment-5932735716
Thanks for the update. I rechecked 202ab98: Pattern is omitted and the SSH timeout is 6000 ms in both the English and Chinese Sentinel pages. Those two points are fixed. There is still a P2 concern with the help routes. In home/docusaurus.config.js, lastVersion is '1.8.0' and current only overrides the label, not the path: https://github.com/apache/hertzbeat/blob/202ab98d552c35b6855e43337353beb38597b64a/home/docusaurus.config.js#L330-L335 With Docusaurus's version routing, this puts current docs under /docs/next/, while /docs/ belongs to 1.8.0. This PR adds the pages only to home/docs and the Chinese current directory; neither 1.8.0 help directory contains redis_sentinel.md or kvrocks.md, and the PR adds no redirects for them. The templates still point to the unversioned URLs. Based on the source, I would therefore expect the new pages at /docs/next/help/{redis_sentinel,kvrocks} and /zh-cn/docs/next/help/{redis_sentinel,kvrocks}, rather than the console's existing destinations. Could you please serve the production build and check these four exact helpLink URLs, confirming that each renders the intended help page rather than a 404? - https://hertzbeat.apache.org/docs/help/redis_sentinel - https://hertzbeat.apache.org/zh-cn/docs/help/redis_sentinel - https://hertzbeat.apache.org/docs/help/kvrocks - https://hertzbeat.apache.org/zh-cn/docs/help/kvrocks For local validation, replace only the origin with the local server address and keep those paths unchanged. A successful docs build alone may not catch URLs supplied by the application YAML. If the mismatch is confirmed, please add the pages to the default version, provide redirects, or align the helpLink values with the generated routes. This is a source-based finding; I have not independently built or served the site. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
