ascherbakoff commented on a change in pull request #3501: ignite-7648 URL: https://github.com/apache/ignite/pull/3501#discussion_r254264038
########## File path: modules/core/src/main/java/org/apache/ignite/spi/TimeoutStrategy.java ########## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.spi; + +/** + * Strategy to calculate next timeout chunk and check if total timeout reached. + */ +public interface TimeoutStrategy { + /** + * Get next timeout based on as Math.min(currentTimeout, remainingTime till totalTimeout reached) + * @return Next calculated timeout. + * @throws IgniteSpiOperationTimeoutException If timeout reached. + */ + public long currentTimeout() throws IgniteSpiOperationTimeoutException; + + /** + * + * @return Gets current value of timeout and calculates value for next retry. + */ + public long getAndCalculateNextTimeout(); + + /** + * Check if total timeout will be reached in now() + timeInFut. + * + * If timeInFut is 0, will check that timeout already reached. + * + * @param timeInFut Some millis in future. + * @return True if total timeout reached. + */ + public boolean checkTimeout(long timeInFut); Review comment: Not needed on interface level. Always same implementation for every strategy, could just always use currentTimeout + delta <= 0. Probably could be implemented as default method. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
