ascherbakoff commented on a change in pull request #3501: ignite-7648 URL: https://github.com/apache/ignite/pull/3501#discussion_r254261587
########## File path: modules/core/src/main/java/org/apache/ignite/spi/ExponentialBackoffTimeoutStrategy.java ########## @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.spi; + +import java.util.Date; + +/** + * Strategy which incorporates retriable network operation, handling of totalTimeout logic. + * It increases startTimeout based on exponential backoff algorithm. + * + * If failure detection is enabled it relies on totalTimeout + * otherwise implements exponential backoff totalTimeout logic based on startTimeout, maxTimeout and retryCnt. + */ +public class ExponentialBackoffTimeoutStrategy implements TimeoutStrategy { + /** Initial startTimeout, ms. */ + private final long startTimeout; + + /** Max startTimeout of the next try, ms. */ + private final long maxTimeout; + + /** Max reconnections count. */ + private final int reconCnt; + + /** Total startTimeout, ms. */ + private final long totalTimeout; + + /** Start of operation to check totalTimeout. */ + private final long start; + + /** Current startTimeout, ms. */ + private long currTimeout; + + /** Backoff coeffient to calculate next timeout.*/ + private double backoffCoeff; + + /** Compute expected backoffConnTimeout delay based on startTimeout, maxTimeout and reconCnt and backoff coeffient. */ + public static long maxBackoffTimeout( + long startTimeout, + long maxTimeout, + long reconCnt, + double backoffCoeff + ) { + long maxBackoffTimeout = startTimeout; + + for (int i = 1; i < reconCnt && maxBackoffTimeout < maxTimeout; i++) + maxBackoffTimeout += nextTimeout(maxBackoffTimeout, maxTimeout, backoffCoeff); + + return maxBackoffTimeout; + } + + /** + * + * @param timeout Timeout. + * @param maxTimeout Maximum startTimeout for backoff function. + * @param backoffCoeff Coefficient to calculate next backoff startTimeout. + * @return Next exponetial backoff totalTimeout. + */ + public static long nextTimeout(long timeout, long maxTimeout, double backoffCoeff) { + return (long) Math.min(timeout * backoffCoeff, maxTimeout); + } + + /** + * + * @param totalTimeout Total startTimeout. + * @param startTimeout Initial connection totalTimeout, will be taken for initial connection and handshake timeouts. + * @param maxTimeout Max connection Timeout. + * @param reconCnt Max number of reconnects. + */ + public ExponentialBackoffTimeoutStrategy( + long totalTimeout, + long startTimeout, + long maxTimeout, + int reconCnt, + double backoffCoeff Review comment: Missing javadoc ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
