ascherbakoff commented on a change in pull request #3501: ignite-7648
URL: https://github.com/apache/ignite/pull/3501#discussion_r254643085
##########
File path:
modules/core/src/main/java/org/apache/ignite/spi/communication/tcp/TcpCommunicationSpi.java
##########
@@ -3262,17 +3277,24 @@ protected GridCommunicationClient
createTcpClient(ClusterNode node, int connIdx)
GridCommunicationClient client = null;
IgniteCheckedException errs = null;
- int connectAttempts = 1;
-
- for (InetSocketAddress addr : addrs) {
- long connTimeout0 = connTimeout;
-
- int attempt = 1;
+ long totalTimeout;
- IgniteSpiOperationTimeoutHelper timeoutHelper = new
IgniteSpiOperationTimeoutHelper(this,
- !node.isClient());
+ if (failureDetectionTimeoutEnabled())
+ totalTimeout = node.isClient() ? clientFailureDetectionTimeout() :
failureDetectionTimeout();
+ else {
+ totalTimeout =
ExponentialBackoffTimeoutStrategy.totalBackoffTimeout(
Review comment:
maxWaitTime should be used. Static method brokes strategy pattern.
totalTimeout should be calculated inside strategy ctor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
