ascherbakoff commented on a change in pull request #3501: ignite-7648
URL: https://github.com/apache/ignite/pull/3501#discussion_r254267669
##########
File path:
modules/core/src/main/java/org/apache/ignite/spi/communication/tcp/TcpCommunicationSpi.java
##########
@@ -3558,26 +3580,23 @@ protected void processClientCreationError(
) throws IgniteCheckedException {
assert errs != null;
- if (X.hasCause(errs, ConnectException.class))
- LT.warn(log, "Failed to connect to a remote node " +
- "(make sure that destination node is alive and " +
- "operating system firewall is disabled on local and remote
hosts) " +
- "[addrs=" + addrs + ']');
-
boolean commErrResolve = false;
IgniteSpiContext ctx = getSpiContext();
- if (connectionError(errs) &&
ctx.communicationFailureResolveSupported()) {
+ if (isRecoverableException(errs) &&
ctx.communicationFailureResolveSupported()) {
commErrResolve = true;
ctx.resolveCommunicationFailure(node, errs);
}
if (!commErrResolve && enableForcibleNodeKill) {
if (ctx.node(node.id()) != null
- && (node.isClient() || !getLocalNode().isClient()) &&
- connectionError(errs)) {
+ && node.isClient()
+ && !getLocalNode().isClient()
+ && isRecoverableException(errs)
+ ) {
+ //only server can fail client for now, as in TcpDiscovery
resolveCommunicationFailure() is not supported.
Review comment:
Formatting
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
