1vanan commented on a change in pull request #6434: IGNITE-11708 "Unable to run
tests in IgniteConfigVariationsAbstractTest subclasses"
URL: https://github.com/apache/ignite/pull/6434#discussion_r285641951
##########
File path:
modules/core/src/test/java/org/apache/ignite/testframework/junits/IgniteConfigVariationsAbstractTest.java
##########
@@ -108,9 +92,17 @@ protected static void
injectTestsConfiguration(VariationsTestsConfig testsCfgInj
return false;
}
+ /** Check that test name is not null. */
+ @Before
+ public void checkTestName(){
Review comment:
I left it from the previous code. Such check already exists in
GridAbstractTest [1].
During run IgniteConfigVariationsAbstractTest subclasses, I did not catch
this assertion. But maybe it exists a specific case in which check is necessary.
[1]
https://github.com/apache/ignite/blob/master/modules/core/src/test/java/org/apache/ignite/testframework/junits/GridAbstractTest.java#L188
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
