1vanan commented on a change in pull request #6434: IGNITE-11708 "Unable to run
tests in IgniteConfigVariationsAbstractTest subclasses"
URL: https://github.com/apache/ignite/pull/6434#discussion_r285632155
##########
File path:
modules/core/src/test/java/org/apache/ignite/testframework/junits/IgniteConfigVariationsAbstractTest.java
##########
@@ -108,9 +92,17 @@ protected static void
injectTestsConfiguration(VariationsTestsConfig testsCfgInj
return false;
}
+ /** Check that test name is not null. */
+ @Before
+ public void checkTestName(){
+ assert getName() != null : "getName returned null";
+ }
+
/** {@inheritDoc} */
@Override protected void beforeTestsStarted() throws Exception {
- assert testsCfg != null;
+ assert testsCfgInjected != null;
+
+ testsCfg = testsCfgInjected;
Review comment:
as I see testsCfg do not change during test methods execution. So the reason
for me was to remove unnecessary initialization.
But I can try to move such initialization to beforeTest() method in
IgniteConfigVariationsAbstractTest class to leave the same logic as it was
before.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
