NSAmelchev commented on a change in pull request #6882: IGNITE-12044: Export 
histogram values as separate JMX attributes.
URL: https://github.com/apache/ignite/pull/6882#discussion_r326154917
 
 

 ##########
 File path: 
modules/core/src/main/java/org/apache/ignite/internal/processors/metric/impl/MetricUtils.java
 ##########
 @@ -133,6 +138,43 @@ private static boolean ensureAllNamesNotEmpty(String... 
names) {
         return true;
     }
 
+    /**
+     * Gets histogram bucket names.
+     *
+     * Example of metric names if bounds are 10,100:
+     *  histogram_0_10 (less than 10)
+     *  histogram_10_100 (between 10 and 100)
+     *  histogram_100_inf (more than 100)
+     *
+     * @param metric Histogram metric.
 
 Review comment:
   missed parameter "cache"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to