NSAmelchev commented on a change in pull request #6882: IGNITE-12044: Export 
histogram values as separate JMX attributes.
URL: https://github.com/apache/ignite/pull/6882#discussion_r326158174
 
 

 ##########
 File path: 
modules/core/src/test/java/org/apache/ignite/internal/metric/JmxMetricExporterSpiTest.java
 ##########
 @@ -131,17 +134,70 @@ public void testFilterAndExport() throws Exception {
 
         assertThrowsWithCause(new RunnableX() {
             @Override public void runx() throws Exception {
-                metricSet(ignite.name(), "filtered", "metric");
+                metricRegistry(ignite.name(), "filtered", "metric");
             }
         }, IgniteException.class);
 
-        DynamicMBean bean1 = metricSet(ignite.name(), "other", "prefix");
+        DynamicMBean bean1 = metricRegistry(ignite.name(), "other", "prefix");
 
         assertEquals(42L, bean1.getAttribute("test"));
         assertEquals(43L, bean1.getAttribute("test2"));
 
-        DynamicMBean bean2 = metricSet(ignite.name(), "other", "prefix2");
+        DynamicMBean bean2 = metricRegistry(ignite.name(), "other", "prefix2");
 
         assertEquals(44L, bean2.getAttribute("test3"));
     }
+
+    /** */
+    @Test
+    public void testHistogramSearchByName() throws Exception {
 
 Review comment:
   I think we should add the case where histogram intervals change.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to