alex-plekhanov commented on a change in pull request #6554: IGNITE-11073: 
Backup page store manager, initial
URL: https://github.com/apache/ignite/pull/6554#discussion_r341161124
 
 

 ##########
 File path: 
modules/core/src/main/java/org/apache/ignite/internal/pagemem/store/PageStore.java
 ##########
 @@ -55,7 +61,18 @@
      * @param keepCrc by default reading zeroes CRC which was on file, but you 
can keep it in pageBuf if set keepCrc
      * @throws IgniteCheckedException If reading failed (IO error occurred).
      */
-    public void read(long pageId, ByteBuffer pageBuf, boolean keepCrc) throws 
IgniteCheckedException;
+    public default void read(long pageId, ByteBuffer pageBuf, boolean keepCrc) 
throws IgniteCheckedException {
 
 Review comment:
   Why we can't just change returned type of this method? It's an internal 
interface with only one implementation, there are no compatibility problems 
should happen, I see no reason to create the new method.
   Also, `Number of read bytes` doesn't required at this level of abstraction. 
Let's use `boolean` success flag instead.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to