alex-plekhanov commented on a change in pull request #6554: IGNITE-11073:
Backup page store manager, initial
URL: https://github.com/apache/ignite/pull/6554#discussion_r341193881
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/file/FilePageStoreManager.java
##########
@@ -673,30 +710,7 @@ private CacheStoreHolder initDir(File cacheWorkDir,
if (dirExisted && !idxFile.exists())
grpsWithoutIdx.add(grpId);
- FileIOFactory pageStoreFileIoFactory = this.pageStoreFileIoFactory;
- FileIOFactory pageStoreV1FileIoFactory =
this.pageStoreV1FileIoFactory;
-
- if (encrypted) {
- pageStoreFileIoFactory = new EncryptedFileIOFactory(
- this.pageStoreFileIoFactory,
- grpId,
- pageSize(),
- cctx.kernalContext().encryption(),
- cctx.gridConfig().getEncryptionSpi());
-
- pageStoreV1FileIoFactory = new EncryptedFileIOFactory(
- this.pageStoreV1FileIoFactory,
- grpId,
- pageSize(),
- cctx.kernalContext().encryption(),
- cctx.gridConfig().getEncryptionSpi());
- }
-
- FileVersionCheckingFactory pageStoreFactory = new
FileVersionCheckingFactory(
- pageStoreFileIoFactory,
- pageStoreV1FileIoFactory,
- igniteCfg.getDataStorageConfiguration()
- );
+ FileVersionCheckingFactory pageStoreFactory =
(FileVersionCheckingFactory)getPageStoreFactory(grpId, encrypted);
if (encrypted) {
int headerSize =
pageStoreFactory.headerSize(pageStoreFactory.latestVersion());
Review comment:
You change `headerSIze` for different instances of `pageStoreFactory` and
`pageStoreV1FileIoFactory`. Before the fix, it was local variables (instances
of `EncryptedFileIOFactory`), after the fix you use class fields (instances of
`AsyncFileIOFactory`), so I think there will be class cast exception if
encryption will be enabled.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
