nizhikov commented on a change in pull request #7471: IGNITE-12701 : Disallow
silent deactivation in CLI and REST.
URL: https://github.com/apache/ignite/pull/7471#discussion_r387515325
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/cluster/GridClusterStateProcessor.java
##########
@@ -115,6 +118,11 @@
/** */
private static final String METASTORE_CURR_BLT_KEY = "metastoreBltKey";
+ /** Warning of unsafe deactivation. */
+ public static final String DATA_LOST_ON_DEACTIVATION_WARNING =
+ "Cluster has caches configured without persistence. " +
+ "During deactivation in-memory data and objects can be lost!";
Review comment:
We should change "*can*" to "*will*" because there is no case when in-memory
data will not be lost after deactivation.
So correct message to the user
`Deactivation stopped. Cluster has in-memory caches(without persistence).
During deactivation, in-memory data will be lost.'
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
