Vladsz83 commented on a change in pull request #7471: IGNITE-12701 : Disallow
silent deactivation in CLI and REST.
URL: https://github.com/apache/ignite/pull/7471#discussion_r387547266
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/commandline/DeactivateCommand.java
##########
@@ -78,6 +81,21 @@
return null;
}
+ /** {@inheritDoc} */
+ @Override public void parseArguments(CommandArgIterator argIter) {
+ force = false;
Review comment:
> Do we need this line? Default `force` value is `false` already.
Yes, we need this. Commands are statefull unfortunately. Without this, next
command usage will go with previous value 'force' param.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
