alex-plekhanov commented on a change in pull request #7616: IGNITE-12853:
Introduced features for the thin client protocol
URL: https://github.com/apache/ignite/pull/7616#discussion_r403929243
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/platform/client/cache/ClientCacheConfigurationSerializer.java
##########
@@ -139,9 +138,9 @@
* Writes the cache configuration.
* @param writer Writer.
* @param cfg Configuration.
- * @param ver Client version.
+ * @param protocolContext Client protocol context.
*/
- static void write(BinaryRawWriterEx writer, CacheConfiguration cfg,
ClientListenerProtocolVersion ver) {
+ static void write(BinaryRawWriterEx writer, CacheConfiguration cfg,
ClientProtocolContext protocolContext) {
Review comment:
Abbreviation should be used for "context" (codestyle, in other classes too)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
